refactor: add precise parameter types to Router test fixtures (#10464)

Author: soccerlover29

tests/system/Router/Controllers/BlogController.php

@@ -21,7 +21,7 @@ public function getIndex(): void
     {
     }
 
-    public function getSomeMethod($first = ''): void
+    public function getSomeMethod(string $first = ''): void
     {
     }
 }

tests/system/Router/Controllers/Index.php

@@ -17,7 +17,7 @@
 
 class Index extends Controller
 {
-    public function getIndex($p1 = ''): void
+    public function getIndex(string $p1 = ''): void
     {
     }
 

tests/system/Router/Controllers/Mycontroller.php

@@ -21,7 +21,7 @@ public function getIndex(): void
     {
     }
 
-    public function getSomemethod($first = ''): void
+    public function getSomemethod(string $first = ''): void
     {
     }
 }

tests/system/Router/Controllers/Remap.php

@@ -18,7 +18,7 @@
 
 class Remap extends Controller
 {
-    public function _remap(string $method, ...$params): string
+    public function _remap(string $method, mixed ...$params): string
     {
         $method = 'process_' . $method;
 

tests/system/Router/Controllers/SubDir/BlogController.php

@@ -21,7 +21,7 @@ public function getIndex(): void
     {
     }
 
-    public function getSomeMethod($first = ''): void
+    public function getSomeMethod(string $first = ''): void
     {
     }
 }

tests/system/Router/Controllers/Subfolder/Home.php

@@ -17,7 +17,7 @@
 
 class Home extends Controller
 {
-    public function getIndex($p1 = null, $p2 = null): void
+    public function getIndex(?string $p1 = null, ?string $p2 = null): void
     {
     }
 }

tests/system/Router/Controllers/Subfolder/Sub/BlogController.php

@@ -21,7 +21,7 @@ public function getIndex(): void
     {
     }
 
-    public function getSomeMethod($first = ''): void
+    public function getSomeMethod(string $first = ''): void
     {
     }
 }

tests/system/Router/DefinedRouteCollectorTest.php

@@ -25,7 +25,7 @@
 #[Group('Others')]
 final class DefinedRouteCollectorTest extends CIUnitTestCase
 {
-    private function createRouteCollection(array $config = [], $moduleConfig = null): RouteCollection
+    private function createRouteCollection(array $config = [], ?Modules $moduleConfig = null): RouteCollection
     {
         $defaults = [
             'Config' => APPPATH . 'Config',
@@ -37,7 +37,7 @@ private function createRouteCollection(array $config = [], $moduleConfig = null)
 
         $loader = service('locator');
 
-        if ($moduleConfig === null) {
+        if (! $moduleConfig instanceof Modules) {
             $moduleConfig          = new Modules();
             $moduleConfig->enabled = false;
         }

tests/system/Router/RouteCollectionReverseRouteTest.php

@@ -35,7 +35,7 @@ protected function setUp(): void
         $this->resetFactories();
     }
 
-    protected function getCollector(array $config = [], array $files = [], $moduleConfig = null): RouteCollection
+    protected function getCollector(array $config = [], array $files = [], ?Modules $moduleConfig = null): RouteCollection
     {
         $defaults = [
             'Config' => APPPATH . 'Config',
@@ -47,7 +47,7 @@ protected function getCollector(array $config = [], array $files = [], $moduleCo
 
         $loader = service('locator');
 
-        if ($moduleConfig === null) {
+        if (! $moduleConfig instanceof Modules) {
             $moduleConfig          = new Modules();
             $moduleConfig->enabled = false;
         }

tests/system/Router/RouteCollectionTest.php

@@ -44,7 +44,7 @@ protected function setUp(): void
         Services::injectMock('superglobals', new Superglobals());
     }
 
-    protected function getCollector(array $config = [], array $files = [], $moduleConfig = null): RouteCollection
+    protected function getCollector(array $config = [], array $files = [], ?Modules $moduleConfig = null): RouteCollection
     {
         $defaults = [
             'Config' => APPPATH . 'Config',
@@ -56,7 +56,7 @@ protected function getCollector(array $config = [], array $files = [], $moduleCo
 
         $loader = service('locator');
 
-        if ($moduleConfig === null) {
+        if (! $moduleConfig instanceof Modules) {
             $moduleConfig          = new Modules();
             $moduleConfig->enabled = false;
         }