[bot] Merge master/47b32167 into rel/dev - #1745
Merged
Merged
Conversation
…parison create_metric_alert addresses a notification one of two ways: `recipients`/ `external_recipients` (raw email addresses) when the channel can send externally, or `internal_recipients` (internal GoodData user ids, never emails) when the channel is restricted to workspace-registered users. _check_recipients only ever read recipients/external_recipients, so any alert delivered the internal way always failed this check regardless of what the fixture expected -- confirmed live: a real, correctly-delivered alert with internal_recipients=['user.<uuid>'] still scored recipients_correct=False, because the code was comparing against a key that's never populated for that delivery path. Resolves the expected email to its internal user id via the Users entities API (GET /entities/users?filter=email==...), lazily -- only when the plain comparison already failed and internal_recipients is actually present, so no unconditional network call is added to the hot path (existing run_agentic_alert_skill tests never mock GoodDataSdk, only ChatClient). Same shape of gap as #1699 (alert_proposals as a confirmation signal): gooddata-eval's evaluator hadn't been taught to read a real tool-response shape yet. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
CodeRabbit review: without an sdk arg, the test couldn't catch a regression where a Users lookup runs before the direct recipient match. Pass a mock sdk and assert get_all_entities_users is not called.
CI's format-check job was failing since these files predated the project's line-length config. Reformat to match.
An email containing ' or \ (e.g. o'hara@example.com) broke the RSQL filter string in _resolve_internal_recipient_ids, and the lookup failure was silently swallowed -- a correctly delivered internal alert would score recipients_correct=False with no diagnostic. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
…quest _resolve_internal_recipient_ids issued one get_all_entities_users call per expected recipient. Replaced with a single RSQL email=in=(...) bulk filter, verified live against the Users entities API (returns only the matching subset, no error on non-existent emails; per-value apostrophe/backslash escaping still applies inside the list). Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
…ients fix(gooddata-eval): check internal_recipients in alert recipients comparison
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## rel/dev #1745 +/- ##
===========================================
+ Coverage 79.69% 79.73% +0.04%
===========================================
Files 272 272
Lines 19024 19041 +17
===========================================
+ Hits 15161 15183 +22
+ Misses 3863 3858 -5 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🚀 Automated PR to perform merge from master into rel/dev with changes up to 47b3216 (created by https://github.com/gooddata/gooddata-python-sdk/actions/runs/32367070852).