refactor: Replace custom readLibraryText with standard VFS readText extension

Author: ghostflyby

src/main/kotlin/facet/MinecraftLibraryDetector.kt

@@ -27,7 +27,6 @@ import com.intellij.openapi.vfs.VirtualFile
 import com.intellij.psi.JavaPsiFacade
 import com.intellij.psi.search.FilenameIndex
 import com.intellij.psi.search.GlobalSearchScope
-import java.nio.charset.StandardCharsets
 import java.util.*
 import java.util.jar.Manifest
 
@@ -102,10 +101,6 @@ fun hasLibraryManifest(scope: GlobalSearchScope, predicate: (Manifest) -> Boolea
         }.getOrDefault(false)
     }
 
-fun VirtualFile.readLibraryText(): String? = runCatching {
-    inputStream.reader(StandardCharsets.UTF_8).use { it.readText() }
-}.getOrNull()
-
 private fun filesByName(name: String, scope: GlobalSearchScope): Collection<VirtualFile> =
     FilenameIndex.getVirtualFilesByName(name, scope)
 

src/main/kotlin/platform/velocity/framework/VelocityPresentationProvider.kt

@@ -22,9 +22,9 @@ package com.demonwav.mcdev.platform.velocity.framework
 
 import com.demonwav.mcdev.facet.ClassMinecraftLibraryDetector
 import com.demonwav.mcdev.facet.hasLibraryFile
-import com.demonwav.mcdev.facet.readLibraryText
 import com.demonwav.mcdev.platform.PlatformType
 import com.intellij.openapi.project.Project
+import com.intellij.openapi.vfs.readText
 import com.intellij.psi.search.GlobalSearchScope
 
 class VelocityLibraryDetector : ClassMinecraftLibraryDetector(
@@ -36,8 +36,8 @@ class VelocityLibraryDetector : ClassMinecraftLibraryDetector(
     override fun isLibraryPresent(project: Project, scope: GlobalSearchScope): Boolean =
         super.isLibraryPresent(project, scope) ||
             hasLibraryFile("javax.annotation.processing.Processor", annotationProcessorsPath, scope) { file ->
-                file.readLibraryText()?.lineSequence()?.any {
+                file.readText().lineSequence().any {
                     it.trim() == "com.velocitypowered.api.plugin.ap.PluginAnnotationProcessor"
-                } == true
+                }
             }
 }