From 417670e8a578896568ec4847963bc33c906240b1 Mon Sep 17 00:00:00 2001 From: Miguel Monteiro Date: Fri, 21 Aug 2026 09:55:44 +0200 Subject: [PATCH] [google-cloud-ndb] Model.get_by_id and get_or_insert should return Self --- stubs/google-cloud-ndb/google/cloud/ndb/model.pyi | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/stubs/google-cloud-ndb/google/cloud/ndb/model.pyi b/stubs/google-cloud-ndb/google/cloud/ndb/model.pyi index 54233f0ab42e..49cbe1185954 100644 --- a/stubs/google-cloud-ndb/google/cloud/ndb/model.pyi +++ b/stubs/google-cloud-ndb/google/cloud/ndb/model.pyi @@ -305,7 +305,7 @@ class Model(_NotEqualMixin, metaclass=MetaModel): ) -> tasklets_module.Future: ... @classmethod def get_by_id( - cls: type[Model], + cls, id: int | str | None, parent: key_module.Key | None = ..., namespace: str | None = ..., @@ -327,7 +327,7 @@ class Model(_NotEqualMixin, metaclass=MetaModel): force_writes: bool | None = ..., _options=..., database: str | None = None, - ) -> Model | None: ... + ) -> Self | None: ... @classmethod def get_by_id_async( cls: type[Model], @@ -355,7 +355,7 @@ class Model(_NotEqualMixin, metaclass=MetaModel): ) -> tasklets_module.Future: ... @classmethod def get_or_insert( - cls: type[Model], + cls, _name: str, parent: key_module.Key | None = ..., namespace: str | None = ..., @@ -377,7 +377,7 @@ class Model(_NotEqualMixin, metaclass=MetaModel): force_writes: bool | None = ..., _options=..., **kw_model_args, - ) -> Model: ... + ) -> Self: ... @classmethod def get_or_insert_async( cls: type[Model],