Skip to content

Commit 5419504

Browse files
committed
Add two open items to debug/SUMMARY.md: route StackitCluster's direct status.Ready assignments through ClusterScope.SetNotReady (per PR #4 review), and standardise speaking variable names/formatting across Go files.
1 parent 241df22 commit 5419504

1 file changed

Lines changed: 13 additions & 1 deletion

File tree

debug/SUMMARY.md

Lines changed: 13 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -231,7 +231,19 @@ the CIDR test.
231231
([machine-recreate-bug.md](machine-recreate-bug.md#follow-up-statusready-is-cleared-on-only-three-of-five-failure-paths))
232232
— the bootstrap-data and credentials paths still leave `ready: true` next to
233233
conditions saying `False`. The cluster controller already does this.
234-
11. Optional e2e specs for the three fixed defects — deferred, with the required
234+
11. Route the four direct `cluster.Status.Ready = false` assignments in
235+
`StackitCluster.reconcileNormal`
236+
(`controller/stackitcluster_infrastructure.go:45,63,91,158`) through
237+
`ClusterScope.SetNotReady` instead, mirroring item 10 on the machine side —
238+
a consistency-only follow-up explicitly flagged as out of scope for PR #4
239+
by [@Herbaert](https://github.com/stackitcloud/cluster-api-provider-stackit/pull/4#discussion_r3803129927).
240+
12. Standardise on speaking variable names and lightly-expanded call
241+
formatting across all Go files, per
242+
[PR #4's diff](https://github.com/stackitcloud/cluster-api-provider-stackit/pull/4/changes/b77942006315e9c320ea8aff09246233d48db230)
243+
— e.g. `stackitcluster_infrastructure.go` spells out `clusterScope`/`cluster`
244+
while `stackitmachine_infrastructure.go` abbreviates the same value to
245+
`s`/`sm`.
246+
13. Optional e2e specs for the three fixed defects — deferred, with the required
235247
work written up per spec in
236248
[test-strategy.md](test-strategy.md#optional-e2e-specs--deferred-and-what-each-would-need).
237249

0 commit comments

Comments
 (0)