Skip to content

Commit 400145f

Browse files
committed
docs(run-store): correct the boundedness claim on inline record output
Only BUILT_IN_ERROR is truncated; a STRING_ERROR, a CUSTOM_ERROR and a cancel-reason error pass through, so the bound for an error payload is the completion body limit and not the offload thresholds. Postgres stores the identical strings, so this is a copy of an existing payload class.
1 parent 31d504c commit 400145f

1 file changed

Lines changed: 3 additions & 1 deletion

File tree

internal-packages/run-store/src/redisSnapshotStore.ts

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,9 @@ export type CompletedWaitpointsPointer = {
5151

5252
/**
5353
* A record's output.
54-
* - `inline` holds the literal value, bounded by the pre-existing offload thresholds.
54+
* - `inline` holds the literal value. MANUAL and DATETIME are bounded by the offload
55+
* thresholds; error outputs are not (only BUILT_IN_ERROR truncates), so the bound is
56+
* the completion body limit. Postgres holds the same strings, so this is a copy.
5557
* - `ref` holds an application/store reference that was already offloaded.
5658
* - `deriveFromRun` means the resolver reads TaskRun.output for completedByTaskRunId.
5759
* Only a RUN record with outputIsError false AND a non-null completedByTaskRunId uses

0 commit comments

Comments
 (0)