Skip to content

Add favorites tab to library Modal [SYNTH-269] - #1454

Open
RoushilS wants to merge 3 commits into
darora1/218/ui-tourfrom
roushils/269/add-favorites-tab
Open

Add favorites tab to library Modal [SYNTH-269]#1454
RoushilS wants to merge 3 commits into
darora1/218/ui-tourfrom
roushils/269/add-favorites-tab

Conversation

@RoushilS

Copy link
Copy Markdown
Contributor

Task

SYNTH-269

Symptom

Users would have to click through years in the library assembly multiple times, which can be annoying.

Solution

Add new tab with frontent favorite display logic, as well as backend default loading of selected assets. Also briefely updated tutorial.

Verification

  • Users can favorite and unfavorite assets
  • Best assets are favorited by default.
  • Existing functionality preserved

Before merging, ensure the following criteria are met:

  • All acceptance criteria outlined in the ticket are met.
  • Necessary test cases have been added and updated.
  • A feature toggle or safe disable path has been added (if applicable).
  • User-facing polish:
    • Ask: "Is this ready-looking?"
  • Cross-linking between Jira and GitHub:
    • PR links to the relevant Jira issue.
    • Jira ticket has a comment referencing this PR.

@RoushilS RoushilS changed the title Add favorites tab [SYNTH-269] Add favorites tab to library Modal [SYNTH-269] Jul 28, 2026
@RoushilS RoushilS self-assigned this Jul 28, 2026
@RoushilS
RoushilS marked this pull request as ready for review July 28, 2026 18:36
@RoushilS
RoushilS requested review from a team as code owners July 28, 2026 18:36
@RoushilS
RoushilS requested review from AlexD717, Dhruv-0-Arora, PepperLola and rutmanz and removed request for a team July 28, 2026 18:36

@rutmanz rutmanz left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Image

Are the year tabs supposed to be gone?

Also I think it might be better to have the favorites tab always present (either as "Favorites" or with the star icon) and just show "No favorited assets yet!" if empty.

Also it looks like the defaults don't work quite right, when I opened it, nothing from the assetpack was favorited.

Also maybe auto-favorite local uploads because they'll probably be likely to use the models they add themselves

Comment thread fission/src/mirabuf/DefaultAssetLoader.ts Outdated
Comment thread fission/src/systems/preferences/PreferenceTypes.ts Outdated
@RoushilS
RoushilS requested a review from rutmanz August 4, 2026 18:58
@Dhruv-0-Arora

Copy link
Copy Markdown
Collaborator

@rutmanz you have to clear storage if the thumbnails + years are not showing up

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants