Skip to content

fix(action): restore Core runtime compatibility - #101

Merged
ivanmilevtues merged 1 commit into
mainfrom
fix/core-runtime-compatibility
Aug 26, 2026
Merged

fix(action): restore Core runtime compatibility#101
ivanmilevtues merged 1 commit into
mainfrom
fix/core-runtime-compatibility

Conversation

@ivanmilevtues

Copy link
Copy Markdown
Member

Summary

  • select Temurin 21 inside the composite action so JDTLS can analyze Java repositories
  • import relation projection from its packaged CodeBoarding 0.13.10 module
  • align renderer mocks with the installed package layout
  • smoke-test the pinned Core release by rendering the checked-in analysis in CI

Verification

  • python3 -m unittest discover -s tests -v — 94 passed
  • pre-commit run --all-files — Black passed
  • Spring PetClinic run confirmed Java 21 starts JDTLS; the stale renderer import was the remaining failure

This is a fix: change so release-please will propose a patch release.

@codeboarding-review

Copy link
Copy Markdown
Contributor

CodeBoarding review · analyzing…

⏳ CodeBoarding is analyzing this pull request's architecture changes.

run 33022252699 · attempt 1

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 1c98444522

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread action.yml
Comment on lines +168 to +170
with:
distribution: temurin
java-version: '21'

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Preserve existing Maven settings when selecting the JDK

When a workflow configures ~/.m2/settings.xml for private dependencies before invoking this composite action, actions/setup-java defaults overwrite-settings to true and replaces that file with its generated GitHub Packages configuration. This can make CodeBoarding's Java dependency resolution incomplete and also breaks later Maven steps in the caller's job; set overwrite-settings: false because this step only needs to select the JDK.

Useful? React with 👍 / 👎.

Comment thread action.yml

- name: Setup Java for CodeBoarding
if: steps.guard.outputs.skip != 'true'
uses: actions/setup-java@v5

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Retain support for runners that cannot execute Node 24 actions

actions/setup-java@v5 moved its runtime to Node 24 and requires Actions Runner v2.327.1 or newer, so otherwise-valid self-hosted and GitHub Enterprise Server jobs on older runners now fail at this step before CodeBoarding starts, including reviews of non-Java repositories. setup-java@v4 can install Temurin 21 without imposing this new runner requirement, so use that major unless dropping older runners is intentional and documented.

Useful? React with 👍 / 👎.

@ivanmilevtues
ivanmilevtues merged commit b735334 into main Aug 26, 2026
7 of 8 checks passed
@ivanmilevtues
ivanmilevtues deleted the fix/core-runtime-compatibility branch August 26, 2026 23:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants