fix(action): restore Core runtime compatibility - #101
Conversation
Amp-Thread-ID: https://ampcode.com/threads/T-01a04035-16e0-717f-8cce-97041e26e175 Co-authored-by: Ivan Milev <ivanmilevtues@gmail.com>
CodeBoarding review · analyzing…⏳ CodeBoarding is analyzing this pull request's architecture changes. run 33022252699 · attempt 1 |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 1c98444522
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| with: | ||
| distribution: temurin | ||
| java-version: '21' |
There was a problem hiding this comment.
Preserve existing Maven settings when selecting the JDK
When a workflow configures ~/.m2/settings.xml for private dependencies before invoking this composite action, actions/setup-java defaults overwrite-settings to true and replaces that file with its generated GitHub Packages configuration. This can make CodeBoarding's Java dependency resolution incomplete and also breaks later Maven steps in the caller's job; set overwrite-settings: false because this step only needs to select the JDK.
Useful? React with 👍 / 👎.
|
|
||
| - name: Setup Java for CodeBoarding | ||
| if: steps.guard.outputs.skip != 'true' | ||
| uses: actions/setup-java@v5 |
There was a problem hiding this comment.
Retain support for runners that cannot execute Node 24 actions
actions/setup-java@v5 moved its runtime to Node 24 and requires Actions Runner v2.327.1 or newer, so otherwise-valid self-hosted and GitHub Enterprise Server jobs on older runners now fail at this step before CodeBoarding starts, including reviews of non-Java repositories. setup-java@v4 can install Temurin 21 without imposing this new runner requirement, so use that major unless dropping older runners is intentional and documented.
Useful? React with 👍 / 👎.
Summary
Verification
python3 -m unittest discover -s tests -v— 94 passedpre-commit run --all-files— Black passedThis is a
fix:change so release-please will propose a patch release.