Skip to content

London | 26-Jul-SDC | Roman Sanaye | Sprint 4 | Implement Cowsay in Python - #621

Open
RomanSanaye wants to merge 3 commits into
CodeYourFuture:mainfrom
RomanSanaye:implement-cowsay-in_python
Open

London | 26-Jul-SDC | Roman Sanaye | Sprint 4 | Implement Cowsay in Python#621
RomanSanaye wants to merge 3 commits into
CodeYourFuture:mainfrom
RomanSanaye:implement-cowsay-in_python

Conversation

@RomanSanaye

@RomanSanaye RomanSanaye commented Jul 28, 2026

Copy link
Copy Markdown

Learners, PR Template

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Changelist

Implemented a Python version of the cowsay command-line application.

Features

  • Accepts a message as a command-line argument.
  • Supports selecting an animal using the --animal option.
  • Uses argparse to parse command-line arguments.
  • Displays the message using the selected animal.
  • Defaults to the cow character when no animal is specified.

The implementation follows the assignment requirements and has been tested with different messages and supported animal options.

Task ID: CYF-1151

@RomanSanaye RomanSanaye added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jul 28, 2026
@github-actions

This comment has been minimized.

@LonMcGregor

Copy link
Copy Markdown
Contributor

Try and re-read the readme file for this task, a few requirements are missing.

Ideally we want a solution that is generic for any/all animals the library offers us, rather than specifically implementing ones the test is looking for.

@LonMcGregor LonMcGregor added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Aug 3, 2026
@RomanSanaye

Copy link
Copy Markdown
Author

Hello, @LonMcGregor ,
Thanks for the feedback. I’ve re-read the README and updated my solution to support all animals from the cowsay library.

@RomanSanaye RomanSanaye added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Aug 4, 2026
@github-actions

github-actions Bot commented Aug 4, 2026

Copy link
Copy Markdown

Results of test:
Your implementation passed all checks.

@github-actions github-actions Bot added Complete Volunteer to add when work is complete and all review comments have been addressed. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Aug 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Complete Volunteer to add when work is complete and all review comments have been addressed. Reviewed Volunteer to add when completing a review with trainee action still to take.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants