feat: add expires_in parameter to asset upload endpoints - #76
Merged
Conversation
jab416171
commented
Aug 24, 2026
jab416171
commented
Contributor
- Add expires_in to post_assets, asset_from_hash, async equivalents
- Add expires_in to _Source, AssetFactory.from_file, AsyncAssetFactory.from_file
- Pass expires_in through upload/from-hash flows
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: Comment |
jab416171
force-pushed
the
feat/asset-expiration
branch
from
August 24, 2026 03:42
4134c22 to
0e49c9f
Compare
- Add expires_in to post_assets, asset_from_hash, async equivalents - Add expires_in to _Source, AssetFactory.from_file, AsyncAssetFactory.from_file - Pass expires_in through upload/from-hash flows
jab416171
force-pushed
the
feat/asset-expiration
branch
from
August 27, 2026 15:48
0e49c9f to
cea5e89
Compare
wei-hai
approved these changes
Aug 27, 2026
Collaborator
|
@jab416171 this is good contribution and we really appreciate it, however, we need to support local ComfyUI, cloud and serverless API in one interface, so unfortunately we need to revert this PR in #109 , we will revisit when we have capacity to support |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.