Route manifest EnvVars into auth_data (EnvVar.inject_into_auth_data) - #10
Merged
Conversation
Adds a single additive, backward-compatible field to the EnvVar contract (default False reproduces today's behavior). When True, the runtime must guarantee the value reaches a credential's auth_data at action-execution time; the source is derived from only_for_custom (server-level secret vs per-credential user input) rather than declared, so no integration-specific branching is needed. Wires the two integrations that currently fail with "missing from auth_data": - google_ads GOOGLE_ADS_DEVELOPER_TOKEN: only_for_custom=True + inject_into_auth_data=True (managed app resolves from server env). - google_merchant_center GOOGLE_MERCHANT_CENTER_MERCHANT_ID: inject_into_auth_data=True (per-credential user input). tools.py is unchanged (both already read these keys from auth_data). The actual injection behavior lands in the modulex runtime; see the external brief. Verification baseline unchanged: 1890 passed, ruff clean, mypy clean for touched files. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds an additive
EnvVar.inject_into_auth_data: bool = Falseto the schema contract and flags the two EnvVars that currently fail with "missing from auth_data":google_adsGOOGLE_ADS_DEVELOPER_TOKEN→only_for_custom=True,inject_into_auth_data=True(managed app resolves from server env).google_merchant_centerGOOGLE_MERCHANT_CENTER_MERCHANT_ID→inject_into_auth_data=True(per-credential user input).tools.pyis unchanged — both already read these keys fromauth_data. The source is derived fromonly_for_custom, so no per-integration runtime branching is needed.Notes
False; the other ~80 integrations dump it asFalseand the runtime injection is a no-op for them.Verification
ruffclean,mypyclean on touched files.🤖 Generated with Claude Code