Update rename disclaimer link and improve test skipping - #2291
Merged
Justin Grote (JustinGrote) merged 3 commits intoMay 15, 2026
Merged
Update rename disclaimer link and improve test skipping#2291Justin Grote (JustinGrote) merged 3 commits into
Justin Grote (JustinGrote) merged 3 commits into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the rename disclaimer URL and broadens CI detection for skipping a slow E2E command-discovery test.
Changes:
- Replaces the rename disclaimer README link with the new
aka.msURL. - Skips the slow
getCommandE2E test on GitHub Actions and other environments that setCI.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
src/PowerShellEditorServices/Services/TextDocument/RenameService.cs |
Updates the rename disclaimer link shown to users. |
test/PowerShellEditorServices.Test.E2E/LanguageServerProtocolMessageTests.cs |
Expands CI skip conditions for the slow CanSendGetCommandRequestAsync test. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Andy Jordan (andyleejordan)
approved these changes
May 15, 2026
Andy Jordan (andyleejordan)
approved these changes
May 15, 2026
Justin Grote (JustinGrote)
deleted the
justingrote/rename-disclaimer-and-skip-test
branch
May 15, 2026 19:38
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The pull request updates the disclaimer link to point to the new aka.ms URL and enhances the test skipping logic to account for additional CI platforms. This change improves clarity and ensures tests run efficiently across different environments.