Skip to content

fix(query-engine): normalize topk labels in binary expressions - #644

Merged
milindsrivastava1997 merged 10 commits into
mainfrom
issue-631-topk-binary-arm
Aug 27, 2026
Merged

fix(query-engine): normalize topk labels in binary expressions#644
milindsrivastava1997 merged 10 commits into
mainfrom
issue-631-topk-binary-arm

Conversation

@milindsrivastava1997

Copy link
Copy Markdown
Contributor

Summary

Fixes #631. PromQL topk(...) binary arms now use the original non-__name__ labels for intermediate vector matching. Standalone Topk output formatting remains unchanged.

The fix covers instant and range paths, including topk + plain, topk + topk, scalar arithmetic, empty joins, and all supported arithmetic operators.

Validation

  • Full query_engine_rust test suite
  • cargo fmt
  • cargo check
  • cargo clippy
  • Pre-commit hooks

All checks pass.

@milindsrivastava1997
milindsrivastava1997 marked this pull request as ready for review August 27, 2026 17:40
@milindsrivastava1997
milindsrivastava1997 marked this pull request as draft August 27, 2026 17:40
@milindsrivastava1997
milindsrivastava1997 marked this pull request as ready for review August 27, 2026 19:53
@milindsrivastava1997
milindsrivastava1997 merged commit aaad01c into main Aug 27, 2026
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

topk(...) as a binary-expr arm: __name__ label mismatch (pre-existing) and metric-name-in-join corruption (#629 Finding 1)

1 participant