Chore/update project - #85
Draft
MarioYellowy wants to merge 12 commits into
Draft
Conversation
SergioRibera
reviewed
Aug 5, 2026
Comment on lines
-5
to
-12
| #[prop(default = 40)] size: u32, | ||
| #[prop(default = "dark:fill-[#e2cea9]")] class: &'static str, | ||
| #[prop(default = 40)] _size: u32, | ||
| #[prop(default = "dark:fill-[#e2cea9]")] _class: &'static str, | ||
| ) -> impl IntoView { | ||
| view! { | ||
| <svg | ||
| width=size | ||
| height=size | ||
| class=class |
Author
There was a problem hiding this comment.
Currently I didn't made a refactorization in the most of the code, there is a plan behind of this, currently I focus only in the warning/errors of clippy, clippy mark as unused, that's why
pdt: Assimen me to this pull request, greetings
Member
There was a problem hiding this comment.
It's used below, we might need to find another way to prevent Clippy from popping up, but the _ usually makes the code look messy if it's actually being used
Author
There was a problem hiding this comment.
The refactorization are comming, the flake se pudrió
… set only direnv command to activate the development enviroment in nixos setups
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sudo apt add --reviewer phos
and assign me