fix: open files read-only during format --check - #5961
Open
avakili-voleon wants to merge 1 commit into
Open
Conversation
format --check only reads files to compare content but opened them with r+, which requires write permission and fails on read-only filesystems in certain CI setups. Use r for check mode and keep r+ for normal format runs that write back to disk. Signed-off-by: Amir Vakili <AVakili@Voleon.com>
avakili-voleon
marked this pull request as ready for review
August 20, 2026 15:25
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
sqlmesh format --checkopened model/audit SQL files withr+even though check mode only reads them. That requires write permission and can fail on read-only filesystems in certain CI setups.This change opens files in
rmode whencheck=True, and keepsr+for normal format runs that write back to disk.Test Plan
test_format_check_read_only_files— chmods a model file to read-only and verifiesformat(check=True)completes without error, reports the file needs reformatting, and leaves the file unchangedmake stylepassesmake fast-testpassesChecklist
make styleand fixed any issuesmake fast-test)