refactor: share the database endpoint picker and the create-database form - #2566
Merged
datlechin merged 2 commits intoAug 28, 2026
Merged
Conversation
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
datlechin
deleted the
refactor/share-database-endpoint-and-create-database-form
branch
August 28, 2026 15:59
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two shared-code changes pulled out of the work on #2487, so that issue's own branch reviews as a
feature rather than as a feature plus a rename. Nothing here changes behaviour.
CompareSyncEndpointbecomesDatabaseEndpointThe type is "one database, on one connection, named well enough to act on". Compare & Sync named it
first, but it answers a question any cross-database operation asks, and the copy work in #2487 needs
the same answer. It moves to
Core/Database/, and its chooser, which walks connection then databasethen schema, moves to
Views/Components/asDatabaseEndpointPicker.CompareSyncEligibilitystays behind inCore/Compare/: whether a driver reports enough for acomparison is Compare's question, not a shared one.
Pure rename, compiler-verified. The endpoint's own tests move with it to
TableProTests/Core/Database/.The create-database form's rules become shared and testable
CreateDatabaseSheetheld the whole form contract inline: which fields are visible, which optionsbelong to which group, what resets when a grouped field's source changes, and which answers are
stale enough that they must not be submitted. A second caller either duplicates that or loses it.
It splits into
CreateDatabaseFormRules, which is pure, andCreateDatabaseOptionsView, whichrenders it. The sheet keeps its own state and loses about 110 lines.
The rules had no tests. They have 12 now, including the two that matter and were never asserted:
a pair the server refuses
CREATE DATABASEWhat I built and tested
verify.sh buildverify.sh test(touched suites)verify.sh lint TablePro TableProTestsverify.sh pluginsandverify.sh abiwere not run and are not needed: nothing underPlugins/changed.
No CHANGELOG entry: nothing user-facing changes, and the rename is internal.