Fix alignment in relaxed atomics spec test - #8961
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The spec test intends to use the natural alignment for all instructions, but it's choosing an alignment based on the memory address type rather than the size of the load/store. This means that sometimes the alignment is too small (4 bytes for an 8-byte load/store in a 32-bit memory), and sometimes the alignment is too large (8 bytes for a 4-byte load/store in a 64-bit memory) both of which are a validation error (but are not in Binaryen today).
Use the size of the load/store as the alignment instead.
Spec reference:
