Upgrade/Install: Check for wp-config.php before wp-config-sample.php - #13249
Upgrade/Install: Check for wp-config.php before wp-config-sample.php#13249ritakikani wants to merge 1 commit into
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
9a4d7b7 to
630e014
Compare
This moves the
wp-config-sample.phpexistence check after the existingwp-config.phpchecks inwp-admin/setup-config.php.This avoids checking for
wp-config-sample.phpwhenwp-config.phpalreadyexists, including environments where
open_basedirrestrictions may triggera warning while checking for the sample file.
Testing
Tested manually with
wp-config.phppresent andwp-config-sample.phptemporarily unavailable.
setup-config.phpcorrectly detected the existingwp-config.phpbeforeattempting to check
wp-config-sample.php.Additional checks performed:
php -l src/wp-admin/setup-config.phpvendor/bin/phpcs src/wp-admin/setup-config.phpgit diff --checkTrac ticket: https://core.trac.wordpress.org/ticket/53298
Use of AI Tools
AI assistance: Yes
Tool(s): ChatGPT
Model(s): GPT-5.6 Sol
Used for: Guidance through the WordPress Core contribution workflow, understanding the ticket, testing steps, Git workflow, and PR description. The code change was reviewed and tested locally by me.
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.