Skip to content

Upgrade/Install: Check for wp-config.php before wp-config-sample.php - #13249

Open
ritakikani wants to merge 1 commit into
WordPress:trunkfrom
ritakikani:ticket-53298
Open

Upgrade/Install: Check for wp-config.php before wp-config-sample.php#13249
ritakikani wants to merge 1 commit into
WordPress:trunkfrom
ritakikani:ticket-53298

Conversation

@ritakikani

Copy link
Copy Markdown

This moves the wp-config-sample.php existence check after the existing
wp-config.php checks in wp-admin/setup-config.php.

This avoids checking for wp-config-sample.php when wp-config.php already
exists, including environments where open_basedir restrictions may trigger
a warning while checking for the sample file.

Testing

Tested manually with wp-config.php present and wp-config-sample.php
temporarily unavailable.

setup-config.php correctly detected the existing wp-config.php before
attempting to check wp-config-sample.php.

Additional checks performed:

  • php -l src/wp-admin/setup-config.php
  • vendor/bin/phpcs src/wp-admin/setup-config.php
  • git diff --check

Trac ticket: https://core.trac.wordpress.org/ticket/53298

Use of AI Tools

AI assistance: Yes
Tool(s): ChatGPT
Model(s): GPT-5.6 Sol
Used for: Guidance through the WordPress Core contribution workflow, understanding the ticket, testing steps, Git workflow, and PR description. The code change was reviewed and tested locally by me.


This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

@github-actions

Copy link
Copy Markdown

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props kikanirita.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@github-actions

Copy link
Copy Markdown

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant