Keep task log text selection alive while scrolling - #71148
Open
Andrushika wants to merge 2 commits into
Open
Conversation
Virtualized log rows are unmounted as they leave the viewport. This destroys selection boundaries and makes text selections collapse or drift during scrolling.
Andrushika
requested review from
bbovenzi,
choo121600,
guan404ming,
pierrejeambrun,
ryanahamilton,
shubhamraj-git and
vatsrahul1001
as code owners
August 5, 2026 05:43
This was referenced Aug 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The log viewer only renders rows inside the virtualized window. When a selection boundary scrolls out of view, its DOM node is removed and the browser selection collapses or drifts.
2026-07-28.1.38.34.mov
What
Listen to
selectionchangeand keep the boundary rows in the virtualizer'srangeExtractor. This keeps at most two extra rows mounted while the user scrolls.After:
2026-08-04.3.42.34.mov
closes: #68846
Was generative AI tooling used to co-author this PR?
Generated-by: Codex (GPT-5) following the guidelines