Clarify which signal each duplicated otel_* config option applies to - #71158
Open
br413 wants to merge 1 commit into
Open
Clarify which signal each duplicated otel_* config option applies to#71158br413 wants to merge 1 commit into
br413 wants to merge 1 commit into
Conversation
Each duplicated otel_* description now states which signal it configures, keeping both [metrics] and [traces] options intact per maintainer guidance. Also restores literal markup in [traces] descriptions. Closes apache#43366
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The \otel_on, \otel_host, \otel_port, \otel_service, \otel_debugging_on, and \otel_ssl_active\ options appear in both the [metrics]\ and [traces]\ sections of the Configuration Reference. Their descriptions did not clearly state which signal each copy configures.
Three [metrics]\ descriptions were also incorrect: \otel_host\ and \otel_interval_milliseconds\ claimed to cover traces, and \otel_service\ described only traces.
This PR keeps both option sets (per @ferruzzi's resolution in #43366) and:
Builds on the approach from closed #70837 (author unable to follow up).
closes: #43366
Test plan
Was generative AI tooling used to co-author this PR?