Fix OpenSearch remote logging crash if port is empty - #71170
Draft
FrankYang0529 wants to merge 1 commit into
Draft
Fix OpenSearch remote logging crash if port is empty#71170FrankYang0529 wants to merge 1 commit into
FrankYang0529 wants to merge 1 commit into
Conversation
Signed-off-by: PoAn Yang <payang@apache.org>
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Followup PR for #70295 (comment).
Why
[opensearch] portdeclaresdefault: ""inprovider.yaml, so the key always resolves andconf.getint("opensearch", "PORT", fallback=9200)never reaches its fallback. The default value""make it raise ValueError onint("").How
[opensearch] portas a string and convert explicitly, treating an empty value as "unset". An unset port still resolves to 9200.Verification
uv run --project providers/opensearch pytest airflow-core/tests/unit/config_templates/test_airflow_local_settings.pyenv -u AIRFLOW__OPENSEARCH__PORT AIRFLOW__LOGGING__REMOTE_LOGGING=True AIRFLOW__OPENSEARCH__HOST=https://opensearch.example.com uv run --project providers/opensearch airflow versionWas generative AI tooling used to co-author this PR?
{pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.