Skip to content

Fix OpenSearch remote logging crash if port is empty - #71170

Draft
FrankYang0529 wants to merge 1 commit into
apache:mainfrom
FrankYang0529:airflow-opensearch-legacy-port
Draft

Fix OpenSearch remote logging crash if port is empty#71170
FrankYang0529 wants to merge 1 commit into
apache:mainfrom
FrankYang0529:airflow-opensearch-legacy-port

Conversation

@FrankYang0529

Copy link
Copy Markdown
Member

Followup PR for #70295 (comment).

Why

  • [opensearch] port declares default: "" in provider.yaml, so the key always resolves and conf.getint("opensearch", "PORT", fallback=9200) never reaches its fallback. The default value "" make it raise ValueError on int("").

How

  • Read [opensearch] port as a string and convert explicitly, treating an empty value as "unset". An unset port still resolves to 9200.

Verification

  • uv run --project providers/opensearch pytest airflow-core/tests/unit/config_templates/test_airflow_local_settings.py
  • env -u AIRFLOW__OPENSEARCH__PORT AIRFLOW__LOGGING__REMOTE_LOGGING=True AIRFLOW__OPENSEARCH__HOST=https://opensearch.example.com uv run --project providers/opensearch airflow version
    • This command fails on main branch, but pass in this PR.

Was generative AI tooling used to co-author this PR?
  • Yes - Claude Code

  • Read the Pull Request Guidelines for more information. Note: commit author/co-author name and email in commits become permanently public when merged.
  • For fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
  • When adding dependency, check compliance with the ASF 3rd Party License Policy.
  • For significant user-facing changes create newsfragment: {pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.

Signed-off-by: PoAn Yang <payang@apache.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant