DNS Provider URL Validation by DaanHoogland · Pull Request #13821 · apache/cloudstack

DaanHoogland · 2026-08-07T10:03:20Z

Description

DnsProviderManagerImpl.addDnsServer/updateDnsServer accepted a user-controlled URL and passed it straight to PowerDnsProvider/PowerDnsClient with zero host validation — no egress check at all, unlike the template/webhook paths.
Added validateDnsServerUrl(), called at the top of addDnsServer and whenever updateDnsServer changes the URL.

Types of changes

Breaking change (fix or feature that would cause existing functionality to change)
New feature (non-breaking change which adds functionality)
Bug fix (non-breaking change which fixes an issue)
Enhancement (improves an existing feature and functionality)
Cleanup (Code refactoring and cleanup, that may add test cases)
Build/CI
Test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Major
Minor

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

codecov · 2026-08-07T10:12:19Z

Codecov Report

❌ Patch coverage is 92.30769% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 19.73%. Comparing base (4e4a26b) to head (22ff345).

Files with missing lines	Patch %	Lines
.../apache/cloudstack/dns/DnsProviderManagerImpl.java	92.30%	1 Missing and 1 partial ⚠️

Additional details and impacted files

@@            Coverage Diff            @@
##               main   #13821   +/-   ##
=========================================
  Coverage     19.73%   19.73%           
- Complexity    19956    19959    +3     
=========================================
  Files          6371     6371           
  Lines        575765   575784   +19     
  Branches      70478    70478           
=========================================
+ Hits         113642   113654   +12     
- Misses       449766   449778   +12     
+ Partials      12357    12352    -5

Flag	Coverage Δ
uitests	`3.41% <ø> (ø)`
unittests	`21.01% <92.30%> (+<0.01%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copilot

Pull request overview

This PR hardens DNS provider configuration by adding pre-connection URL validation in DnsProviderManagerImpl so user-supplied DNS provider endpoints are checked (and normalized via trimming) before being persisted or handed to provider clients.

Changes:

Add validateDnsServerUrl() and invoke it in addDnsServer and when updateDnsServer changes the URL.
Normalize URLs by trimming before duplicate checks and persistence.
Update and extend unit tests to cover trimming behavior and rejection of invalid URLs (e.g., loopback, missing scheme).

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File	Description
server/src/main/java/org/apache/cloudstack/dns/DnsProviderManagerImpl.java	Adds URL trimming + validation before duplicate checks/persistence and before provider validation.
server/src/test/java/org/apache/cloudstack/dns/DnsProviderManagerImplTest.java	Adjusts existing tests and adds new cases for trimming and invalid URL rejection.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

DaanHoogland · 2026-08-10T12:25:26Z

+    private void validateDnsServerUrl(String url) {
+        if (StringUtils.isBlank(url)) {
+            return;
+        }
+        UriUtils.validateUrl(url);
+    }


I think this comment makes sense (cc @sudo87 ) however, implementing this like co-pilot suggests makes no sense. ftp: or mailto: or many other scheme prefixes would have to be checked. Would we accept any others than http-like ones? (ref https://en.wikipedia.org/wiki/List_of_URI_schemes) I wouldn’t mind dns: (not listed on the page I shared)

@DaanHoogland @sudo87 @weizhouapache I think the scheme should be ignored here for this validation. The DNS provider should either use the appropriate scheme automatically, or check whether the provided URL has the expected scheme.

sudo87 · 2026-08-07T11:15:30Z

clgtm, not sure if copilot comment regarding "file" protocol is valid

Copilot

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

Suppressed comments (2)

server/src/main/java/org/apache/cloudstack/dns/DnsProviderManagerImpl.java:171

The JavaDoc claims UriUtils.validateUrl(String) enforces an http/https scheme, but UriUtils.validateUrl also allows file. Either the JavaDoc should be corrected, or validateDnsServerUrl should explicitly enforce http/https (and document that additional restriction).

     * Rejects a DNS provider URL that resolves to an illegal address before any provider client is given
     * the chance to connect to it. See {@link UriUtils#validateUrl(String)} for the exact rules enforced
     * (including the requirement that the URL declares an {@code http}/{@code https} scheme).
     * Expects {@code url} to already be trimmed.
     */

server/src/main/java/org/apache/cloudstack/dns/DnsProviderManagerImpl.java:176

UriUtils.validateUrl permits the file scheme (see UriUtils.validateUrl), so the new DNS server URL validation currently still allows file: URLs. For a provider endpoint this is unexpected and can open up local-file / non-HTTP URL handling paths in downstream clients; it also contradicts the intent to require http/https URLs.

    private void validateDnsServerUrl(String url) {
        if (StringUtils.isBlank(url)) {
            throw new IllegalArgumentException("URL cannot be blank.");
        }
        UriUtils.validateUrl(url);

winterhazel · 2026-08-14T17:17:54Z

+    private void validateDnsServerUrl(String url) {
+        if (StringUtils.isBlank(url)) {
+            return;
+        }
+        UriUtils.validateUrl(url);
+    }


@DaanHoogland @sudo87 @weizhouapache I think the scheme should be ignored here for this validation. The DNS provider should either use the appropriate scheme automatically, or check whether the provided URL has the expected scheme.

Copilot

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

Copilot

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

github-actions · 2026-08-15T08:37:08Z

🔴 Test Coverage Grade: `D` — Marginal

Metric	Value
Line coverage	24.51%
Branch coverage	18.67%

Grade Scale

Grade	Line Coverage	Meaning
🟢 A	≥ 80%	Excellent - this code sleeps well at night 😴
🟡 B	60-79%	Good - almost there, don't stop now 😉
🟠 C	40-59%	Acceptable - your code is wearing a seatbelt, but no airbags 😬
🔴 D	20-39%	Marginal - boldly shipping where no test has gone before 🖖
⛔ F	< 20%	Failing - tests? what tests? 🔥

Branch coverage is shown as a secondary signal. Grade is determined by line coverage.
View full Actions run

weizhouapache · 2026-08-17T07:17:14Z

@blueorangutan package

blueorangutan · 2026-08-17T07:18:10Z

@weizhouapache a [SL] Jenkins job has been kicked to build packages. It will be bundled with no SystemVM templates. I'll keep you posted as I make progress.

winterhazel

I didn't test, but the code looks good

winterhazel · 2026-08-21T15:34:37Z

@blueorangutan package

blueorangutan · 2026-08-21T15:36:04Z

@winterhazel a [SL] Jenkins job has been kicked to build packages. It will be bundled with no SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2026-08-21T16:19:48Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 18948

weizhouapache · 2026-08-24T10:57:47Z

@blueorangutan test

blueorangutan · 2026-08-24T11:00:03Z

@weizhouapache a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

winterhazel · 2026-08-24T12:41:48Z

I performed the following tests:

As a root admin, register, update and delete a PowerDNS server in a private network: ok
As a root admin, attempt to register a DNS server providing a any local/link local/loopback/multicast address: results in an error (illegal URL), ok
As a domain admin, attempt to register, update and delete a PowerDNS server in a private network: results in an error (restricted to root admins), ok

weizhouapache · 2026-08-24T13:30:34Z

@blueorangutan package

weizhouapache · 2026-08-24T13:30:53Z

@blueorangutan package

blueorangutan · 2026-08-24T13:32:04Z

@weizhouapache a [SL] Jenkins job has been kicked to build packages. It will be bundled with no SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2026-08-24T13:44:19Z

Packaging result [SF]: ✖️ el8 ✖️ el9 ✖️ debian ✖️ suse15. SL-JID 18970

weizhouapache · 2026-08-24T14:05:03Z

@blueorangutan package

blueorangutan · 2026-08-24T14:06:04Z

@weizhouapache a [SL] Jenkins job has been kicked to build packages. It will be bundled with no SystemVM templates. I'll keep you posted as I make progress.

weizhouapache · 2026-08-24T14:20:46Z

@blueorangutan package

blueorangutan · 2026-08-24T14:22:04Z

@weizhouapache a [SL] Jenkins job has been kicked to build packages. It will be bundled with no SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2026-08-24T14:52:56Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 18971

blueorangutan · 2026-08-24T15:08:31Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 18972

sonarqubecloud · 2026-08-24T15:37:37Z

Quality Gate passed

Issues
10 New issues
0 Accepted issues

Measures
0 Security Hotspots
69.7% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

weizhouapache · 2026-08-24T15:38:47Z

@blueorangutan test

blueorangutan · 2026-08-24T15:40:04Z

@weizhouapache a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

blueorangutan · 2026-08-25T01:41:13Z

[SF] Trillian test result (tid-16813)
Environment: kvm-ol8 (x2), zone: Advanced Networking with Mgmt server ol8
Total time taken: 49513 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr13821-t16813-kvm-ol8.zip
Smoke tests completed. 144 look OK, 1 have errors, 11 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_02_ssl_offloading_project_vpc	`Failure`	721.97	test_ssl_offloading.py
all_test_volumes	`Skipped`	---	test_volumes.py
all_test_vpc_conserve_mode	`Skipped`	---	test_vpc_conserve_mode.py
all_test_vpc_firewall_rules	`Skipped`	---	test_vpc_firewall_rules.py
all_test_vpc_ipv6	`Skipped`	---	test_vpc_ipv6.py
all_test_vpc_redundant	`Skipped`	---	test_vpc_redundant.py
all_test_vpc_router_nics	`Skipped`	---	test_vpc_router_nics.py
all_test_vpc_vpn	`Skipped`	---	test_vpc_vpn.py
all_test_webhook_delivery	`Skipped`	---	test_webhook_delivery.py
all_test_webhook_lifecycle	`Skipped`	---	test_webhook_lifecycle.py
all_test_host_maintenance	`Skipped`	---	test_host_maintenance.py
all_test_hostha_kvm	`Skipped`	---	test_hostha_kvm.py

DaanHoogland added this to the 4.23.0 milestone Aug 7, 2026

DaanHoogland requested review from sudo87, weizhouapache and winterhazel and a lite review from Copilot August 7, 2026 10:03

DaanHoogland added the Severity:BLOCKER label Aug 7, 2026

weizhouapache reviewed Aug 7, 2026

View reviewed changes

Comment thread server/src/main/java/org/apache/cloudstack/dns/DnsProviderManagerImpl.java Outdated

Copilot started reviewing on behalf of DaanHoogland August 7, 2026 10:15 View session

Copilot AI reviewed Aug 7, 2026

View reviewed changes

DaanHoogland commented Aug 10, 2026

View reviewed changes

Comment thread server/src/main/java/org/apache/cloudstack/dns/DnsProviderManagerImpl.java Outdated

Copilot AI review requested due to automatic review settings August 10, 2026 12:20

Daan Hoogland and others added 3 commits August 10, 2026 14:20

validate DNS server URLs in provider framework

9714982

fixes

1fa1638

Apply suggestion from @DaanHoogland

6981138

DaanHoogland force-pushed the dnsProviderUrlValidate branch from a555469 to 6981138 Compare August 10, 2026 12:20

Copilot started reviewing on behalf of DaanHoogland August 10, 2026 12:21 View session

Copilot AI reviewed Aug 10, 2026

View reviewed changes

Comment thread server/src/test/java/org/apache/cloudstack/dns/DnsProviderManagerImplTest.java Outdated

winterhazel reviewed Aug 14, 2026

View reviewed changes

address (some) review comments

b88552b

Copilot AI review requested due to automatic review settings August 15, 2026 07:27

Copilot AI reviewed Aug 15, 2026

DaanHoogland requested a lite review from Copilot August 15, 2026 07:28

Copilot AI reviewed Aug 15, 2026

apache deleted a comment from github-actions Bot Aug 15, 2026

winterhazel reviewed Aug 21, 2026

View reviewed changes

Comment thread server/src/main/java/org/apache/cloudstack/dns/DnsProviderManagerImpl.java Outdated

Comment thread server/src/main/java/org/apache/cloudstack/dns/DnsProviderManagerImpl.java Outdated

address review comments

738bc24

winterhazel approved these changes Aug 21, 2026

View reviewed changes

winterhazel marked this pull request as ready for review August 24, 2026 12:42

weizhouapache closed this Aug 24, 2026

weizhouapache reopened this Aug 24, 2026

github-actions Bot mentioned this pull request Aug 24, 2026

Allow root admin to configure DNS servers on behalf of a specific user/domain and support project-scoped DNS servers #13911

Open

weizhouapache added 2 commits August 24, 2026 16:03

Merge remote-tracking branch 'origin/main' into dnsProviderUrlValidate

488e9f2

fix build error

3892328

server: optimize DnsProviderManagerImplTest

22ff345

Uh oh!

Conversation

DaanHoogland commented Aug 7, 2026

Description

Types of changes

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

Uh oh!

Uh oh!

codecov Bot commented Aug 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

DaanHoogland Aug 10, 2026

Choose a reason for hiding this comment

Uh oh!

winterhazel Aug 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

sudo87 commented Aug 7, 2026

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

winterhazel Aug 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions Bot commented Aug 15, 2026

🔴 Test Coverage Grade: D — Marginal

Grade Scale

Uh oh!

weizhouapache commented Aug 17, 2026

Uh oh!

blueorangutan commented Aug 17, 2026

Uh oh!

Uh oh!

Uh oh!

winterhazel left a comment

Choose a reason for hiding this comment

Uh oh!

winterhazel commented Aug 21, 2026

Uh oh!

blueorangutan commented Aug 21, 2026

Uh oh!

blueorangutan commented Aug 21, 2026

Uh oh!

weizhouapache commented Aug 24, 2026

Uh oh!

blueorangutan commented Aug 24, 2026

Uh oh!

winterhazel commented Aug 24, 2026

Uh oh!

weizhouapache commented Aug 24, 2026

Uh oh!

weizhouapache commented Aug 24, 2026

Uh oh!

blueorangutan commented Aug 24, 2026

codecov Bot commented Aug 7, 2026 •

edited

Loading

winterhazel Aug 14, 2026 •

edited

Loading

winterhazel Aug 14, 2026 •

edited

Loading

🔴 Test Coverage Grade: `D` — Marginal