Convert Tagsync into webapp and add metrics - #1107
Open
Sanket-Shelar wants to merge 3 commits into
Open
Conversation
pradeepagrawal8184
requested changes
Jul 29, 2026
| import java.util.List; | ||
| import java.util.Map; | ||
|
|
||
| public class EmbeddedServer { |
Contributor
There was a problem hiding this comment.
Try to use existing embedded webserver rather copying and introducing one more.
Sanket-Shelar
force-pushed
the
RANGER-4153-Tagsync-webapp-docker
branch
from
August 24, 2026 10:45
30b1dea to
7dc5afe
Compare
| LOG.debug("==> AtlasRESTTagSource.run()"); | ||
|
|
||
| while (true) { | ||
| StopWatch eventStopWatchRest = new StopWatch().start(); |
Contributor
There was a problem hiding this comment.
it seems updateTotalUploadsTime(timeElapsed) runs every loop iteration and includes the full sleep interval, not just upload work. Metric name suggests upload time but measures cycle time.
| @@ -183,6 +187,11 @@ public void run() { | |||
| LOG.debug("==> This server is running passive mode"); | |||
Contributor
There was a problem hiding this comment.
is this should be part of else block ?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Converted tagsync into webapp, made changes to start tagsync in docker with webapp and added metrics for tagsync
How was this patch tested?
Local build passed and tested tags are syncing in docker
RANGER-4153: Ranger Tagsync - Convert to Web Application
RANGER-5706: Support for Tagsync as Webapp in Docker
RANGER-5707: Add/ Update metric details for Ranger TagSync