[SPARK-58585][SQL] Extract a helper for INVALID_EXTERNAL_VALUE errors in CatalystTypeConverters - #57786
Open
uros-b wants to merge 1 commit into
Open
[SPARK-58585][SQL] Extract a helper for INVALID_EXTERNAL_VALUE errors in CatalystTypeConverters#57786uros-b wants to merge 1 commit into
uros-b wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Extracts a private helper
throwInvalidExternalValue(value, dataType): NothinginCatalystTypeConvertersand routes the eight byte-identicalINVALID_EXTERNAL_VALUEthrow sites through it.Why are the changes needed?
The eight throw blocks were identical apart from the trailing
dataTypeargument, so the same six lines were repeated eight times. Factoring them into one helper removes about 31 lines of duplication with no behavior change: the same error class and the same three message parameters (other,otherClass,dataType) are produced, and theNothingreturn type keeps every match arm's result type unchanged.Does this PR introduce any user-facing change?
No.
How was this patch tested?
Behavior-preserving refactor. Existing conversion tests, which assert the error condition and its parameters via
checkError, cover these paths. No new tests needed.Was this patch authored or co-authored using generative AI tooling?
Generated-by: Claude Code (Opus 4.8)