fix: entity naming regex escaping, visibility division-by-zero, widget null guard

[PedroHenrique0713]

Summary

Three utility bug fixes in the Appsmith frontend.

1. Regex special characters in entity naming cause incorrect auto-numbering (utils/AppsmithUtils.tsx)

getNextEntityName and getDuplicateName construct new RegExp(^${prefix}(\d+)$) without escaping regex metacharacters in the prefix. If a widget/entity name prefix contains ., $, *, +, ?, ^, {, }, (, ), [, ], |, or \, these are interpreted as regex operators, causing incorrect index calculation and potential name collisions. Fix: escape regex special characters before constructing the pattern.

2. Division by zero in isElementVisibleInContainer (utils/helpers.tsx)

When an element has zero dimensions (hidden via display:none, not yet rendered, or 0px width/height), elementArea is 0. The division visibleArea / 0 produces Infinity or NaN, both of which pass the >= percentage check, falsely reporting hidden elements as visible. Fix: return false when elementArea === 0.

3. TypeError on stale widget ID in getWidgetElementToScroll (utils/helpers.tsx)

canvasWidgets[widgetId] returns undefined if the widget was deleted between URL parsing and the deferred requestIdleCallback scroll handler. Accessing .parentId on undefined throws an uncaught TypeError. Fix: return null when widget is not found.

Testing

• TypeScript compilation passes
• Existing utility logic preserved (prefix escaping is transparent for normal names)
• Edge cases verified: zero-area elements, stale/deleted widget IDs, regex metacharacters in prefixes

Summary by CodeRabbit

• Bug Fixes
  • Improved automatic naming when prefixes contain special characters.
  • Corrected visibility detection for elements with no measurable area.
  • Prevented errors when attempting to scroll to a widget that is no longer available.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: e71fe2c7-b608-4519-8ccb-c531749efc23

📥 Commits

Reviewing files that changed from the base of the PR and between 583811d and aa1f7ce.

📒 Files selected for processing (2)

• app/client/src/utils/AppsmithUtils.tsx
• app/client/src/utils/helpers.tsx

---

Walkthrough

Changes

Utility safety fixes

Layer / File(s)	Summary
Name-generation regex escaping app/client/src/utils/AppsmithUtils.tsx	Name-generation helpers escape regex-special characters in prefixes before matching numeric suffixes.
Widget visibility and lookup guards app/client/src/utils/helpers.tsx	Visibility checks return false for zero-area elements, and widget lookup returns null when the widget is missing.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Poem

Prefixes meet their match,
Empty widgets take no fall,
Zero areas rest—
Safe helpers guard the path,
Tiny fixes, steady craft.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Description check	⚠️ Warning	The description covers the fixes and testing, but it omits the required issue reference, Automation, Cypress results, and Communication sections.	Add the template-required Fixes issue link, Automation /ok-to-test tag, Cypress test results section, and the Communication checkbox block.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly summarizes the main bug-fix themes in the PR and matches the changed utilities.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[github-actions]

This PR has not seen activitiy for a while. It will be closed in 7 days unless further activity is detected.

[PedroHenrique0713]

Still active, and still applicable to release.

The PR is three small independent fixes in two utility files:

• getNextEntityName / getDuplicateName built a RegExp from an unescaped prefix, so an entity name containing regex metacharacters could produce wrong matches and name collisions
• isElementVisibleInContainer divided by the element height, so a 0px element yielded Infinity/NaN and was treated as visible
• getWidgetElementToScroll read .parentId without a null guard, throwing a TypeError when the widget was missing

The branch is mergeable and the checks are green. Happy to split this into one PR per fix if that makes review easier, or to add tests if you would like them covered.