fix: use GET+POST instead of PUT for Confluence Server attach_content (#1660) - #1666
Open
mrcrysta1 wants to merge 1 commit into
Open
fix: use GET+POST instead of PUT for Confluence Server attach_content (#1660)#1666mrcrysta1 wants to merge 1 commit into
mrcrysta1 wants to merge 1 commit into
Conversation
…atlassian-api#1660) Confluence Server doesn't support PUT on the child/attachment endpoint. This fix checks if the attachment exists first (GET), then creates (POST) or updates (PUT on specific attachment ID) accordingly. Fixes atlassian-api#1660
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1660. Confluence Server does not support PUT on the child/attachment endpoint. Changed attach_content() to GET existing attachment first, then POST to create or PUT on specific attachment ID to update.