fix(frame): self-configure engine rules when the run command arrives - #294
Open
Aaryan430 wants to merge 2 commits into
Open
fix(frame): self-configure engine rules when the run command arrives#294Aaryan430 wants to merge 2 commits into
Aaryan430 wants to merge 2 commits into
Conversation
Frames register a11y-engine rules via the one-shot CONFIGURE_A11YENGINE broadcast. A frame created after the broadcast, or whose window listeners were wiped by a document.write() rewrite (GPT ad creatives), keeps answering axe.ping/axe.start with a default audit and fails the whole run in normalizeRunOptions with 'unknown rule `fieldset-missing-legend` in options.rules'. The engine bundle in every frame already holds the rules and checks, and options.a11yEngineConfig already carries the engine flags with axe.start. Call a11yEngine.ensureConfigured(options) (added in a11y-engine-core) before running rules so the frame registers its engine rules from the config that travels with the command — no broadcast or listener dependency. Guarded no-op when the engine bundle is absent or the audit is already configured. Companion PR: browserstack/a11y-engine (a11yEngine.ensureConfigured). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
chikara1608
approved these changes
Aug 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.