Skip to content

Log original package resolution errors - #451

Open
huytdps13400 wants to merge 1 commit into
callstackincubator:nextfrom
huytdps13400:fix/369-log-package-resolution-errors
Open

Log original package resolution errors#451
huytdps13400 wants to merge 1 commit into
callstackincubator:nextfrom
huytdps13400:fix/369-log-package-resolution-errors

Conversation

@huytdps13400

Copy link
Copy Markdown

Summary

  • retain the original resolver message when resolvePackageRoot fails
  • include the package name and exact invalid/missing entry-point path in debug output
  • add a cross-platform regression test using a package whose main file is missing
  • add a patch changeset for react-native-node-api

Verification

  • focused TDD regression: failed before the fix with 0 !== 1, passes after the fix
  • pnpm run build
  • pnpm run lint
  • pnpm run prettier:check
  • pnpm run depcheck
  • pnpm run test — host 62 tests, gyp-to-cmake 30 tests, cmake-rn 16 tests passed
  • git diff --check

Closes #369.

Preserve the resolver error message when dependency scanning cannot locate a package entry point.

Closes callstackincubator#369.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Would be good to have a debug log for failed module resolution

1 participant