Add --fail-on-error to the host link command - #453
Open
huytdps13400 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #269
Summary
--fail-on-errorto the hostlinkcommandThe strict resolver is internal and separate from the existing tolerant wrapper. That keeps the default API/behavior intact and lets the diagnostic logging work in #451 land independently; I will rebase this PR if that resolver change merges first.
Tests
The CLI integration fixture declares
broken-packagewith anexportstarget pointing to a missing file:link --android: exit 0 and emit the existing warninglink --android --fail-on-error: exit 1 and includebroken-packageplusmissing.js, not an unknown-option errorTDD evidence: the strict-mode test initially failed because the CLI reported
unknown option '--fail-on-error'; it passes after the implementation.Validation
pnpm install --frozen-lockfile— Node 24.16.0 / pnpm 10.33.0pnpm run buildpnpm test— 109/109 passed across host, cmake-rn, and gyp-to-cmakepnpm lintpnpm prettier:checkpnpm depcheckreact-native-node-api help link— option presentgit diff --check