Add cflags support to gyp-to-cmake - #454
Open
huytdps13400 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #99
Summary
cflagsin parsedbinding.gypinputtarget_compile_options(<target> PRIVATE ...)for those flagsgyp-to-cmakeThis intentionally leaves
cflags_cc,ldflags, variables, conditions, andtarget_defaultsto their separate tracked issues.TDD evidence
Parser tests first failed because valid
cflagswere rejected as an extra property and malformed values were accepted. After adding the parser boundary, transformer tests failed because notarget_compile_optionscommand was emitted. Both stages are now green.Coverage includes:
cflagsinputValidation
Node 24.16.0 / pnpm 10.33.0:
pnpm --filter gyp-to-cmake test— 38/38 passedpnpm run build— passedpnpm test— 115/115 passed across gyp-to-cmake, host, and cmake-rnpnpm lint— passedpnpm prettier:check— passedpnpm depcheck— passedgit diff --check— passed