refactor: widen Response body and Formatter data typing to mixed - #10480
Merged
paulbalandan merged 1 commit intoAug 24, 2026
Merged
Conversation
michalsn
approved these changes
Aug 23, 2026
paulbalandan
force-pushed
the
response-format-body-mixed
branch
from
August 24, 2026 06:55
72a267f to
cc7f71f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The formatters can genuinely take in any form of data but their phpdocs unnecessarily narrow down their inputs to
array|object|string. This widens it tomixed. Consequently,Response::setJSONnow also takes amixedbody instead of the incorrectly narrowed one.Checklist: