docs: stop the ecosystem diagram drawing local checks as a dead end - #10
Merged
Merged
Conversation
The diagram gave the Action and the MCP server an endpoint each — CI
Pipeline, AI Coding Agent — but the CLI and pre-commit node had only one
outgoing edge, to the Action. The place the page elsewhere calls the
cheapest and most important ("the check that runs in CI is the same one
that runs in your commit-msg hook") was drawn as a dead end inside the
engine box.
It also mixed levels: Config pointed at a subgraph while CLI pointed out
of one, so the arrows were not comparable.
Now one config, one engine, three surfaces, three places they run —
symmetric, and the local path arrives somewhere. Verified with the real
mermaid parser rather than by eye: 8 nodes and 7 edges, matching the
source. The previous version parsed and rendered correctly too, so this
changes what the picture claims, not whether it draws.
Dropping the CLI-versus-Python-API split loses no accuracy that matters
here — the Action does shell out to the CLI and the MCP server does
import commit_check.engine, but which of the two a surface uses is a
contributor's question, not a landing page's.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01U9zFxq8V4qxG4aMzJhGBFn
✅ Deploy Preview for commit-check ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe documentation replaces the grouped ecosystem Mermaid diagram with a simpler left-to-right flow from ChangesEcosystem diagram
Estimated code review effort: 1 (Trivial) | ~2 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The last structural item from the review. It turned out to be a modelling problem rather than the "this diagram is heavier than it earns" I had it down as.
The local path was drawn as a dead end
The diagram gave the Action and the MCP server an endpoint each, but the CLI and pre-commit node had exactly one outgoing edge — to the Action:
So the picture showed commit-check reaching CI and an AI agent, and never reaching a developer — while the prose a few hundred pixels above says the opposite:
It also mixed levels:
Configpointed at a subgraph whileCLIpointed out of one, so the arrows were not comparable to each other.Now
One config, one engine, three surfaces, three places they run. Symmetric, and the local path arrives somewhere.
graph LR Config["cchk.toml"] --> Engine["commit-check"] Engine --> Hook["CLI and pre-commit hook"] Engine --> Action["commit-check-action"] Engine --> MCP["commit-check-mcp"] Hook --> Dev["Your laptop"] Action --> CI["CI pipeline"] MCP --> Agent["AI coding agent"]On what was dropped
The old diagram split the engine into
CLI & pre-commitandPython API, and both edges were accurate — I checked rather than assumed.commit-check-actionshells out to the CLI (run_commit_check()in itsmain.py), andcommit-check-mcpimports the engine directly:Which of the two a surface consumes is a contributor's question, though, not a landing page's — so the split is gone and no claim went with it.
Test plan
mkdocs build --strictclean; 8 tests passmermaid.parse()thenrender(), giving 8 nodes and 7 edges, matching the sourceNote
Material loads mermaid from a CDN that the proxy here blocks, so the diagram does not render in my local build. That is why it was validated against the mermaid library directly. Worth a glance at the deploy preview to confirm it draws in place.
With this, the review list is down to one item: the "Trusted by" wording, which needs your judgement on real-world usage rather than mine.
Separately, the
--compactnaming inconsistency from that list is now filed upstream as commit-check/commit-check#528 — it is a change tocommit-check, not to this site.Generated by Claude Code
Summary by CodeRabbit