Refactor landing page hero and clean up stylesheet - #6
Conversation
The author-name failure in the troubleshooting page was still in the
pre-2.13 format: no rule ID, `Type ... => ` instead of `CC101 ... ==> `,
an "It doesn't match regex:" line the package no longer prints at all,
and no `Docs:` link.
tests/docs_sync_test.py did not catch it. Its guard matches
`(CC\d{3}) (\S+) check failed ==>`, which only describes the *new*
format, so a sample still written in the old one is invisible to it.
Also: the configuration page announced "three ways" above a list of
four, and the two blog posts linked Conventional Branch at its old
GitHub Pages URL while every other page uses conventionalbranch.org.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01U9zFxq8V4qxG4aMzJhGBFn
The page carried two: one from the hero in overrides/home.html and one from index.md's own `# Commit Check`. Removing the markdown heading made it worse — Material injects a heading into any page whose content has none, so the page ended up titled "Commit Check" and "Home" at once. Move the hero into index.md instead. Its H1 is then part of the page content, nothing is injected, and the template override is no longer needed. Three things follow from the hero now sitting inside the content column: the "edit this page" pencil floated into it (hidden — a landing page is not one anybody edits), the title needed negative margins to still reach the column edges, and it needed a responsive size, having overflowed the viewport at a flat 3rem on a phone. The hero's primary button also pointed at getting-started/quickstart/, a URL retired when that page was merged away, so the landing page's main call to action went through a client-side redirect stub. Drop the CSS that nothing selects: a second, unused hero implementation (.cc-hero, including a rule meant to hide exactly the duplicate heading above), .stats-grid, .mdx-*, .md-banner, .card-content, .md-tabs__*, table.rules-index, and two keyframes nothing animates. The mobile drawer was hardcoded to Material's default indigo rather than the brand blue beside it, and --commit-check-logo-color-yellow held #ffffff. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01U9zFxq8V4qxG4aMzJhGBFn
docs/demo.gif is 611 KB of the docs directory's 868 KB and nothing links to it; demo.tape (the script that generated it) and static/logo.png are unreferenced too. All three were copied into every build and deployed. Add robots.txt so the generated sitemap.xml is announced rather than left for crawlers to guess at. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01U9zFxq8V4qxG4aMzJhGBFn
✅ Deploy Preview for commit-check ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Warning Review limit reached
Next review available in: 37 minutes You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (3)
📝 WalkthroughWalkthroughThe documentation site now uses an inline homepage hero, revised shared styling, updated documentation links and configuration guidance, corrected troubleshooting output, and a new ChangesDocumentation site refresh
Estimated code review effort: 3 (Moderate) | ~20 minutes Suggested labels: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@docs/stylesheets/extra.css`:
- Around line 53-58: Update the .hero .twemoji rule by inserting a blank line
between the --md-icon-size custom property and the display declaration to
satisfy declaration-empty-line-before.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: e83ecdf3-9af3-4630-9930-d0d195cbf8d5
⛔ Files ignored due to path filters (2)
docs/demo.gifis excluded by!**/*.gifdocs/static/logo.pngis excluded by!**/*.png
📒 Files selected for processing (11)
docs/assets/extra.cssdocs/blog/posts/configuring-commit-check.mddocs/blog/posts/introducing-commit-check.mddocs/configuration.mddocs/demo.tapedocs/index.mddocs/overrides/home.htmldocs/overrides/main.htmldocs/robots.txtdocs/stylesheets/extra.cssdocs/troubleshoot.md
💤 Files with no reviewable changes (2)
- docs/overrides/home.html
- docs/demo.tape
…fter it Stylelint's declaration-empty-line-before flags a declaration that directly follows a custom property. The rule predates this branch — the block moved here unchanged — but it is the file's only occurrence, so fixing it costs a blank line and leaves nothing behind. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01U9zFxq8V4qxG4aMzJhGBFn
Moving the hero into the page content to fix the duplicate heading put it inside the width-capped content column, so its blue background stopped at the column edges and left white gutters either side — visibly narrower than the production landing page. Put it back in the template, where it spans the window with no full-bleed hack, and keep the heading fix by giving index.md a hidden `# Commit Check`. That heading exists only to stop Material injecting one of its own: the injected title uses the nav label, "Home", which is what made the landing page show two competing headings in the first place. The hidden copy is display:none, so it is out of the accessibility tree and the hero's remains the only heading a reader or a crawler sees. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01U9zFxq8V4qxG4aMzJhGBFn
2 participants
Summary
Restructured the landing page hero from a template-based approach to inline markdown, consolidated hero styling into the main stylesheet, and removed unused CSS rules and assets.
Key Changes
Landing Page Structure:
overrides/home.htmltemplate to inline HTML/markdown inindex.mdtemplate: home.htmlfrom index.md frontmatteroverrides/main.htmlto prevent duplicate page titles on homepageStylesheet Consolidation:
docs/assets/extra.csstodocs/stylesheets/extra.css.cc-heroclass definitions and moved equivalent styles to.heroclassclamp()for font sizing andmin()for paragraph width.headerlink) on hero title:has()selectorCSS Improvements:
@keyframes gradientShift,@keyframes heart,@keyframes pulse)#4051b5withvar(--md-primary-fg-color)for consistency--commit-check-logo-color-yellowwith--cc-hero-button-bgrgba()color values for consistency>) for readabilityRemoved Assets:
docs/demo.tape(VHS demo script)docs/demo.gif(generated demo animation)docs/static/logo.pngAdded Files:
docs/robots.txtfor search engine crawling directivesDocumentation Updates:
troubleshoot.mdto reflect new error code formathttps://claude.ai/code/session_01U9zFxq8V4qxG4aMzJhGBFn
Summary by CodeRabbit