fix / place inline suppression where it will actually work for multi-location warnings - #109
Merged
davidramnero merged 2 commits intoAug 28, 2026
Conversation
…location warnings
danmar
reviewed
Aug 28, 2026
| // Copy indentation from line affected by diagnostic | ||
| const indent = lineText.match(/^\s*/)?.[0] ?? ""; | ||
|
|
||
| var affectedLine = diagnostic.range.start.line; |
Contributor
There was a problem hiding this comment.
do we check somewhere that the first location is in the same file? the locations for a warning can point at different files.
Collaborator
Author
There was a problem hiding this comment.
very good point! Fixed
danmar
approved these changes
Aug 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note: the code actions still appear on what the extension considers the main location (i.e. last location in the warnings locations array), but the suppression comment will appear above the first location from the warnings locations array (see pictures).
