fix: update libaom POSIX_C_SOURCE patch context for current CMakeLists.txt - #1224
Merged
crazywhalecc merged 1 commit intoAug 5, 2026
Merged
Conversation
…s.txt libaom's main moved the aom_encoder_stats target from if(ENABLE_EXAMPLES) at CMakeLists.txt:269 to if(ENABLE_APPS) at line 312, so the hunk no longer matches and patch fails outright, breaking any build that falls back to a source build of libaom (e.g. musl targets with no pre-built asset). Same fix as crazywhalecc#1223, backported to main (v2); that one only landed on v3.
henderkes
approved these changes
Aug 5, 2026
crazywhalecc
approved these changes
Aug 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
libaom's
mainmoved theaom_encoder_statstarget fromif(ENABLE_EXAMPLES)at CMakeLists.txt:269 toif(ENABLE_APPS)at line 312 (aCONFIG_HIGHWAYblock got inserted above it). Sincelibaom_posix_implict.patchis applied with plainpatch -p1against a fresh git checkout of libaom'smain, the hunk no longer matches andpatchfails outright, aborting the whole build.This breaks https://github.com/php/frankenphp CI on
main/v2 (musl targets falling back to source build for libaom):Same root cause as #1223, which fixed this on
v3only. This backports the identical hunk-context update tomain.