Yh cyber windowed blending sampler by yh-cyber · Pull Request #53 · cssu/terrain-diffusion

yh-cyber · 2026-08-21T23:14:51Z

Summary

Validation

scripts/quality-check.sh passes locally
Appropriate /test commands were run and are passing (e.g. /test gpu)
Unit tests were added / e2e tests were added where applicable
Manual testing, if applicable (describe further): added test_sampler file to add unit tests, all pass

Checklist

The change is focused and easy to review.
Tests were added or updated for behaviour changes.
No secrets, generated files, or files that only make sense on my machine are included.
Relevant documentation is updated.

Additional Comments

I think there might be something wrong with scripts/quality-check.sh for me.

This is what I got when I ran scripts/quality-check.sh

$ scripts/quality-check.sh
==> Checking formatting (ruff format --check)
17 files already formatted

==> Checking code style (ruff check)
error: a value is required for '[FILES]...' but none was supplied

For more information, try '--help'.

Found style problems. Many can be fixed automatically with:
  scripts/format-check.sh --fix
(terrain-diffusion) 


$ uv run ruff check src tests
All checks passed!
(terrain-diffusion)

coveralls · 2026-08-21T23:16:17Z

Coverage Report for CI Build 32797978609

Coverage increased (+1.0%) to 97.822%

Details

Coverage increased (+1.0%) from the base build.
Patch coverage: 162 of 162 lines across 2 files are fully covered (100%).
No coverage regressions found.

Uncovered Changes

No uncovered changes found.

Coverage Regressions

No coverage regressions found.

Coverage Stats


Relevant Lines:	505
Covered Lines:	494
Line Coverage:	97.82%
Coverage Strength:	0.98 hits per line

💛 - Coveralls

KurbyDoo

overall the structure looks good, just some things to clean up function boundaries and make testing easier

KurbyDoo · 2026-08-22T06:24:45Z

I have a fix for the script error? Could you take a look #54

…d pytest-mocker to project dependencies

… yh-cyber-windowed-blending-sampler

yh-cyber · 2026-08-23T03:29:14Z

I've implemented all changes!

KurbyDoo

Right now the windows are dependent on the region which is fine for now, later we will work to make them independent of the requested region and instead based on a global coordinate space. I'll make tickets for that later

KurbyDoo

thanks for addressing my comments, looks good to merge after this

KurbyDoo · 2026-08-25T00:02:47Z

+        window_size = 3
+        step = 2
+
+        pipeline.generate.side_effect = lambda patch: patch


Can you mock the function to return something more human readable. Right now this test just makes noise, its hard to tell how the output is affected, instead can you just make it return constant 1s?

KurbyDoo · 2026-08-25T00:03:13Z

+    The step is smaller than the window, which is what makes them overlap.
+    If window_size does not divide evenly, throws an assertion error."""
+
+    assert region_height % window_size == 0


Sorry, replace with step not window size

…om/cssu/terrain-diffusion into yh-cyber-windowed-blending-sampler

yh-cyber · 2026-08-25T01:34:19Z

np, thnx. once you take a look and resolve the conversations, ill squash and merge.

yh-cyber added 22 commits August 12, 2026 16:52

first subticket: defining boundaries

e79fc17

starting on second subticket

5e18683

starting on second subticket

3d64f9b

working on window_postions function

89ba124

adding to sampler.py

beb3931

fixed problem in test_sampler

fb3d757

adding to #33

cb3be37

adding to tests/sampler

10897e9

finished test class for #33

7dba7ee

minor fix

fc3fe36

Merge branch 'main' into yh-cyber-windowed-blending-sampler

beb9bca

completed #33

4036106

starting #34

afb2ea1

finished tests for #34

c8765cb

finished #34

94f3a6f

setting up for #35

347bbae

layout structure for produce_region

6d8af62

done produce_region, working on tests

fac8f56

working on fakestore

5f739e2

Merge branch 'main' into yh-cyber-windowed-blending-sampler

82d9964

finished subissue 35

13a135e

fixing script quality check errors

e6641cc

yh-cyber linked an issue Aug 21, 2026 that may be closed by this pull request

Clean every window and add the results into the region grids #35

Open

yh-cyber requested a review from KurbyDoo August 21, 2026 23:15

This was linked to issues Aug 21, 2026

Create the starting noise for a region #34

Open

Work out where the windows go over a region #32

Open

Build the weight grid for a patch #33

Open

Defined Boundaries #50

Open

Define the component boundaries #5

Open

Windowed Blending Sampler #4

Open

KurbyDoo requested changes Aug 22, 2026

View reviewed changes

yh-cyber added 8 commits August 22, 2026 15:32

working on requested changes

45f33c5

sampler.py fixed, working on test_sampler.py

bc5b1e1

fixing script errors

6d314f7

fixed all issues except 1, one more test to be added for window. adde…

e10439f

…d pytest-mocker to project dependencies

Merge branch 'main' of https://github.com/cssu/terrain-diffusion into…

90e96e7

… yh-cyber-windowed-blending-sampler

added assertion for edge_len >1 in weight_grid

aaf1dac

added last rrequested change

fa6f1b6

added comment to clarify

ee0696c

yh-cyber requested a review from KurbyDoo August 23, 2026 15:08

KurbyDoo approved these changes Aug 23, 2026

View reviewed changes

Comment thread src/terrain_diffusion/sampler.py Outdated

Comment thread pyproject.toml Outdated

Comment thread .coverage Outdated

implemented changes

d8ace93

yh-cyber requested a review from KurbyDoo August 24, 2026 16:03

Merge branch 'main' into yh-cyber-windowed-blending-sampler

59abe52

KurbyDoo approved these changes Aug 25, 2026

View reviewed changes

yh-cyber added 3 commits August 24, 2026 21:25

fixed window/step assertion

e75a75c

Merge branch 'yh-cyber-windowed-blending-sampler' of https://github.c…

f073cfc

…om/cssu/terrain-diffusion into yh-cyber-windowed-blending-sampler

fixed test_deterministic_region

0a3f225

Uh oh!

Conversation

yh-cyber commented Aug 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Validation

Checklist

Additional Comments

Uh oh!

coveralls commented Aug 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Coverage Report for CI Build 32797978609

Coverage increased (+1.0%) to 97.822%

Details

Uncovered Changes

Coverage Regressions

Coverage Stats

💛 - Coveralls

Uh oh!

KurbyDoo left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

KurbyDoo commented Aug 22, 2026

Uh oh!

yh-cyber commented Aug 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

KurbyDoo left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

KurbyDoo left a comment

Choose a reason for hiding this comment

Uh oh!

KurbyDoo Aug 25, 2026

Choose a reason for hiding this comment

Uh oh!

yh-cyber Aug 25, 2026

Choose a reason for hiding this comment

Uh oh!

KurbyDoo Aug 25, 2026

Choose a reason for hiding this comment

Uh oh!

yh-cyber Aug 25, 2026

Choose a reason for hiding this comment

Uh oh!

yh-cyber commented Aug 25, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

yh-cyber commented Aug 21, 2026 •

edited

Loading

coveralls commented Aug 21, 2026 •

edited

Loading

yh-cyber commented Aug 23, 2026 •

edited

Loading