feat(kernel): forward socket timeout - #931
Merged
Merged
Conversation
![peco-review-bot[bot]](https://avatars.githubusercontent.com/in/3801177?s=60&v=4){kind=small}
There was a problem hiding this comment.
Verdict: 1 Low
Looks good — clean, well-tested forwarding of _socket_timeout to the kernel's request_timeout_secs, with the Thrift path and its 900 default untouched and unset correctly deferring to the kernel's 120s default. One low note: negative values are forwarded unvalidated despite the docs framing the contract around positive/zero values.
eric-wang-1990
temporarily deployed
to
azure-prod
August 26, 2026 04:50 — with 
GitHub Actions
Inactive
GitHub Actions
Inactive
eric-wang-1990
approved these changes
Aug 26, 2026
vuanhphung
enabled auto-merge
August 26, 2026 05:26
vuanhphung
force-pushed
the
vu-phung/forward-kernel-request-timeout
branch
from
August 26, 2026 05:30
221fa08 to
78eb536
Compare
vuanhphung
had a problem deploying
to
azure-prod
August 26, 2026 05:30 — with
GitHub Actions
Failure
GitHub Actions
Failure
Signed-off-by: Vu Anh Phung <vu.phung@databricks.com>
Signed-off-by: Vu Anh Phung <vu.phung@databricks.com>
Signed-off-by: Vu Anh Phung <vu.phung@databricks.com>
Signed-off-by: Vu Anh Phung <vu.phung@databricks.com>
vuanhphung
force-pushed
the
vu-phung/forward-kernel-request-timeout
branch
from
August 26, 2026 05:52
78eb536 to
dd7c8b4
Compare
This was referenced Aug 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Forward the connector's existing
_socket_timeoutto the kernel's PyO3request_timeout_secsbinding introduced in databricks/databricks-sql-kernel#288. Positive values become total HTTP request deadlines; unset or zero selects the kernel's 120-second default.The kernel pin is updated to the merged binding commit. Focused kernel client/session tests pass, and the changed files pass Black.
This PR was created with GitHub MCP.