fix(ci): retry the Windows build and skip the redundant test-step rebuild - #173
Merged
Conversation
…uild unit-test / test (windows-latest, *) has failed repeatedly on main (37% of the last 40 CI push runs) with STATUS_DLL_INIT_FAILED (exit -1073741502 / 3221225794) crashing turbo's native build toolchain (rolldown, via tsdown/vite) mid-build — an environment fault unrelated to the code under test, never seen on ubuntu. - scripts/ci-retry.ts wraps a command with bounded retries and surfaces the real exit code once the budget is spent, so a genuine compile error still fails the run. - package.json: pnpm run ci:build runs the existing build through it. - .github/workflows/ci.yml: unit-test's Build step now runs ci:build; its Unit Test step runs plain vitest instead of build && vitest, since the Build step already produced a fresh dist/ for the same checkout — halving the number of full-monorepo native builds per job and with it the crash's attack surface.
✅ Deploy Preview for devfra ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
unit-test / test (windows-latest, *)has been failing intermittently onmain— 37% of the last 40 CI push runs failed, always on this job, never on ubuntu, never a real test assertion. Every failure traces back toturbo run build's native toolchain (rolldown, via tsdown/vite) crashing mid-build withSTATUS_DLL_INIT_FAILED(exit-1073741502/3221225794), on a different package each time — a Windows-runner environment fault, not a code bug.Fix
scripts/ci-retry.ts: wraps a command with a bounded number of retries, surfacing the real exit code once the budget is spent (a genuine compile error still fails after all attempts).package.json: addsci:build, which runs the existingbuildscript through the retry wrapper..github/workflows/ci.yml: theunit-testjob's Build step now runsci:build; its Unit Test step runsvitestdirectly instead ofpnpm run test(build && vitest), since the Build step already produced a freshdist/for the same checkout. This halves the number of full-monorepo native builds per job, and with it the crash's attack surface.Verified locally:
pnpm run ci:buildcompletes a full monorepo build, andpnpm exec vitest runagainst that build passes all 98 test files / 1058 tests.Created with the help of an AI agent.