cli/command/service: preserve mount order on force update - #7227
Open
kawmy wants to merge 1 commit into
Open
Conversation
Signed-off-by: Kamyar mofakhami <41609894+kawmy@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
- What I did
Fixed
docker service update --forceso it preserves the existing service mount order when no mount options are supplied.This prevents a subsequent identical
docker stack deployfrom detecting a mount-order difference and unnecessarily rolling the service again.Fixes #7226
- How I did it
Changed
updateService()to callupdateMounts()only when--mount-addor--mount-rmwas explicitly changed.Added a regression test that performs a force-only update and verifies that:
ForceUpdateis incremented.- How to verify it
Run:
The regression test, all service update tests, and the complete service package passed locally in a disposable container environment.
- Human readable description for the release notes