cli: use configured endpoint for proxy lookup - #7232
Open
Sakshamm-Goyal wants to merge 1 commit into
Open
Conversation
Signed-off-by: Saksham Goyal <sakshamgoyal1510@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
- What I did
Use the configured Docker endpoint, rather than a connection helper's internal HTTP placeholder, when selecting per-daemon proxy configuration for container create/run and image build.
Fixes #5797.
- How I did it
Added a shared daemon-host resolver that prefers the original endpoint and falls back to the API client's host for test and compatibility paths. Added a regression covering an SSH endpoint whose API client uses
http://docker.example.cominternally.- How to verify it
TZ=UTC ./scripts/with-go-mod.sh go test ./cli/command ./cli/command/container ./cli/command/image -count=1Configure distinct
defaultandssh://daemon.example.comentries underproxies, then create or run a container through that SSH context. The container receives the SSH endpoint's proxy values.- Human readable description for the release notes
- A picture of a cute animal (not mandatory but encouraged)
Not included.