GC.WaitForPendingFinalizers again - #3222
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The engine calls
GC.Collecta second time afterGC.WaitForPendingFinalizers, presumably because a finalizer may allocate. But it doesn't wait for finalizers to complete the second time. Some types may revive themselves and allocate again every time the GC collects, likeGen2GcCallback(dotnet/runtime#101536). This causes a race condition where our allocation measurement may capture those background allocations. Adding an extraGC.WaitForPendingFinalizersshould fix that race (of course it doesn't help if the benchmark causes the GC to run naturally, but that's unavoidable).