fix(starlite): Gate request body collection on data_collection experiment - #7260
Merged
Conversation
ericapisani
marked this pull request as ready for review
August 26, 2026 13:40
sentrivana
approved these changes
Aug 26, 2026
Contributor
Codecov Results 📊✅ 118295 passed | ⏭️ 6732 skipped | Total: 125027 | Pass Rate: 94.62% | Execution Time: 420m 10s 📊 Comparison with Base Branch
➖ Removed Tests (1)View removed tests
All tests are passing successfully. ✅ Patch coverage is 100.00%. Project has 2479 uncovered lines. Coverage diff@@ Coverage Diff @@
## main #PR +/-##
==========================================
+ Coverage 90.27% 90.27% —%
==========================================
Files 193 193 —
Lines 25472 25474 +2
Branches 9378 9378 —
==========================================
+ Hits 22992 22995 +3
- Misses 2480 2479 -1
- Partials 1432 1431 -1Generated by Codecov Action |
…ment Attach `request.data` only when "incoming_request" is present in `data_collection.http_bodies`. When the experiment is unset, behaviour is unchanged; when it is set, it takes precedence over `send_default_pii`. Refs PY-2419 Refs #6283
ericapisani
force-pushed
the
py-2419-request-body-starlite
branch
from
August 26, 2026 16:19
59e4a8f to
71be800
Compare
The test module uses `from __future__ import annotations`, so the quoted annotation `data: "Dict[str, Any]"` is stored as the literal string `'"Dict[str, Any]"'`. `get_type_hints` evaluates that to the plain string `'Dict[str, Any]'`, which becomes a `ForwardRef` that Python <= 3.10 never resolves further. Starlite builds its OpenAPI schema eagerly in `Starlite.__init__`, so the unresolvable `ForwardRef` made `starlite_app_factory()` raise `ImproperlyConfiguredException` and took down the entire starlite suite on py3.8. Dropping the quotes resolves correctly on every Python version.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Attach
request.dataonly when "incoming_request" is present indata_collection.http_bodies. When the experiment is unset, behaviour isunchanged; when it is set, it takes precedence over
send_default_pii.Refs PY-2419
Refs #6283