Skip to content

chore: Drop tags auto-set by the SDK - #7261

Merged
sentrivana merged 5 commits into
major/3.0from
ivana/major/remove-tags
Aug 27, 2026
Merged

chore: Drop tags auto-set by the SDK#7261
sentrivana merged 5 commits into
major/3.0from
ivana/major/remove-tags

Conversation

@sentrivana

@sentrivana sentrivana commented Aug 26, 2026

Copy link
Copy Markdown
Contributor

Description

Many of the set_tag calls were only present in non-span-streaming branches, which will be completely removed anyway, and we've already migrated those tags, if applicable, to span attributes in the scope of span first.

Issues

Closes https://linear.app/getsentry/issue/PY-1940/remove-tags-auto-set-by-the-sdk

@linear-code

linear-code Bot commented Aug 26, 2026

Copy link
Copy Markdown

PY-1940

@github-actions

github-actions Bot commented Aug 26, 2026

Copy link
Copy Markdown
Contributor

Codecov Results 📊

110526 passed | ❌ 1 failed | ⏭️ 5428 skipped | Total: 115955 | Pass Rate: 95.32% | Execution Time: 376m 6s

📊 Comparison with Base Branch

Metric Change
Total Tests 📉 -9072
Passed Tests 📉 -7768
Failed Tests
Skipped Tests 📉 -1304

➕ New Tests (1)

View new tests
  • test_cache_spans_item_size[True]
    • File: tests.integrations.django.test_cache_module
    • Status: ❌ Failing

➖ Removed Tests (1)

View removed tests
  • test_continuous_profiler_auto_start_and_stop_sampled[non-experiment-gevent]
    • File: tests.profiler.test_continuous_profiler

❌ Failed Tests

test_cache_spans_item_size[True]

File: tests.integrations.django.test_cache_module
Suite: py3.11-django-v4.2.30
Error: tests/integrations/django/test_cache_module.py:758: in test_cache_spans_item_size assert not spans[0]["attributes"]["cache.hit"] E assert not True

Stack Trace
tests/integrations/django/test_cache_module.py:758: in test_cache_spans_item_size
    assert not spans[0]["attributes"]["cache.hit"]
E   assert not True

✅ Patch coverage is 100.00%. Project has 2251 uncovered lines.
✅ Project coverage is 90.56%. Comparing base (base) to head (head).

Coverage diff
@@            Coverage Diff             @@
##          main       #PR       +/-##
==========================================
+ Coverage    90.24%    90.56%    +0.32%
==========================================
  Files          193       185        -8
  Lines        25474     23857     -1617
  Branches      9378      8780      -598
==========================================
+ Hits         22988     21606     -1382
- Misses        2486      2251      -235
- Partials      1431      1373       -58

Generated by Codecov Action

@sentrivana
sentrivana marked this pull request as ready for review August 26, 2026 14:19
@sentrivana
sentrivana requested a review from a team as a code owner August 26, 2026 14:19
@sentrivana
sentrivana merged commit d2b4b1d into major/3.0 Aug 27, 2026
124 of 126 checks passed
@sentrivana
sentrivana deleted the ivana/major/remove-tags branch August 27, 2026 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants