fix(starlette): Use url transaction source for host routing - #7266
Draft
mjq wants to merge 1 commit into
Draft
Conversation
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit 563ea47. Configure here.
Contributor
Codecov Results 📊✅ 118306 passed | ⏭️ 6732 skipped | Total: 125038 | Pass Rate: 94.62% | Execution Time: 414m 56s 📊 Comparison with Base Branch
➖ Removed Tests (1)View removed tests
All tests are passing successfully. ✅ Patch coverage is 85.71%. Project has 2486 uncovered lines. Files with missing lines (1)
Coverage diff@@ Coverage Diff @@
## main #PR +/-##
==========================================
+ Coverage 90.24% 90.24% —%
==========================================
Files 193 193 —
Lines 25474 25473 -1
Branches 9378 9378 —
==========================================
+ Hits 22988 22987 -1
- Misses 2486 2486 —
- Partials 1431 1431 —Generated by Codecov Action |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When host routing, we don't have a route and instead fall back to the request path for the transaction name. This should be given transaction source
url(for raw URLs) instead of the current value ofroute(for parameterized routes).This matters for #7183, where the mis-categorized transaction source would lead to bad data in
http.route. (Bug found by Cursor in #7183 (comment) when reviewing that PR).