fix(issues): Handle has:trace on error events - #121271
Open
scttcper wants to merge 4 commits into
Open
Conversation
The has:trace filter compared promoted UUID trace IDs against an empty string, so error event stats returned a 400. Check context key presence instead and cover the issue-scoped event and user series.\n\nCo-Authored-By: Codex <noreply@openai.com>
Spell out the behavior this endpoint test protects. Co-Authored-By: Codex <noreply@openai.com>
The span filter hit the same empty-value conversion problem as trace IDs, but failed as an invalid hex integer. Use context key presence for both and cover their filtering behavior. Co-Authored-By: Codex <noreply@openai.com>
Use one setup and exercise both trace existence filters in the same behavior test. Co-Authored-By: Codex <noreply@openai.com>
has:trace on error events
scttcper
marked this pull request as ready for review
August 5, 2026 00:09
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
has:traceandhas:trace.spanfilters on error event stats were comparing promoted trace values against an empty string, returning a 400 instead of chart data.example