Skip to content

fix(deps): Bump seroval to patch critical deserialization vuln - #121304

Merged
oioki merged 1 commit into
masterfrom
oioki/fix-seroval-cve-2026-59940
Aug 5, 2026
Merged

fix(deps): Bump seroval to patch critical deserialization vuln#121304
oioki merged 1 commit into
masterfrom
oioki/fix-seroval-cve-2026-59940

Conversation

@oioki

@oioki oioki commented Aug 5, 2026

Copy link
Copy Markdown
Member

Bumps the transitive seroval dependency from 1.5.0 to 1.5.6, patching a critical deserialization type confusion in seroval.fromJSON() (GHSA-mv8w-475r-vwqw, CVSS 9.8) where attacker-controlled JSON could invoke unintended methods during deserialization.

seroval is pulled in transitively via solid-js, which several TanStack devtools packages (react-devtools, react-form-devtools, react-pacer-devtools) depend on. solid-js's existing dependency range already permitted the patched version, so this is a lockfile-only refresh (pnpm update seroval seroval-plugins --lockfile-only) — no package.json changes.

Fixes GHSA-mv8w-475r-vwqw

seroval < 1.5.3 has a type confusion in fromJSON() that lets attacker-controlled JSON invoke unintended methods during deserialization (GHSA-mv8w-475r-vwqw / CVE-2026-59940, CVSS 9.8).

seroval is pulled in transitively via solid-js, which several TanStack devtools packages (react-devtools, react-form-devtools, react-pacer-devtools) depend on. solid-js's existing dependency range already permitted the patched version, so refreshing the lockfile (pnpm update seroval seroval-plugins --lockfile-only) was enough; no package.json changes needed.

Fixes GHSA-mv8w-475r-vwqw
@socket-security

Copy link
Copy Markdown

Warning

Socket is a new tool Security team is testing out, feel free to ignore this alert for now but we encourage you to act on it.
Please provide any feedback you have in #discuss-security slack channel ❤️

Action Severity Alert  (click "▶" to expand/collapse)
Warn High
Obfuscated code: npm seroval is 90.0% likely obfuscated

Confidence: 0.90

Location: Package overview

From: pnpm-lock.yamlnpm/@tanstack/react-devtools@0.9.9npm/@tanstack/react-pacer-devtools@0.5.3npm/@tanstack/react-form-devtools@0.2.20npm/seroval@1.5.6

ℹ Read more on: This package | This alert | What is obfuscated code?

Next steps: Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support@socket.dev.

Suggestion: Packages should not obfuscate their code. Consider not using packages with obfuscated code.

Mark the package as acceptable risk. To ignore this alert only in this pull request, reply with the comment @SocketSecurity ignore npm/seroval@1.5.6. You can also ignore all packages with @SocketSecurity ignore-all. To ignore an alert for all future pull requests, use Socket's Dashboard to change the triage state of this alert.

View full report

@oioki

oioki commented Aug 5, 2026

Copy link
Copy Markdown
Member Author

Obfuscated code: npm seroval is 90.0% likely obfuscated
Confidence: 0.90

Location: Package overview

This was the case since the beginning of time, seems like it is a core function of that package:
lxsmnsyc/seroval@d9eefed

@oioki
oioki marked this pull request as ready for review August 5, 2026 14:23
@oioki
oioki requested a review from a team as a code owner August 5, 2026 14:23
@oioki
oioki merged commit 3baeb19 into master Aug 5, 2026
60 of 61 checks passed
@oioki
oioki deleted the oioki/fix-seroval-cve-2026-59940 branch August 5, 2026 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants