Ruby: Document missing BeginExpr flow. - #22397
Merged
Merged
Conversation
aschackmull
added
the
no-change-note-required
aschackmull
marked this pull request as ready for review
August 20, 2026 11:47
Contributor
There was a problem hiding this comment.
Pull request overview
Adds regression coverage documenting missing local value flow through Ruby BeginExpr assignments with rescue, else, and ensure clauses.
Changes:
- Adds two
BeginExprassignment scenarios with expected missing flows. - Updates generated data-flow, taint-step, and node snapshots.
Show a summary per file
| File | Description |
|---|---|
local_dataflow.rb |
Adds BeginExpr flow cases. |
DataflowStep.expected |
Updates data-flow snapshot. |
TaintStep.expected |
Updates taint-step snapshot. |
Nodes.expected |
Updates node snapshot. |
Review details
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
- Files reviewed: 4/4 changed files
- Comments generated: 0
- Review effort level: Balanced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Ruby
BeginExprast node is currently not included in the CFG, so related flow breaks. This extends the local flow qltest to document this.