Skip to content

Fixes docs for directoryBrowse enabled examples #22419

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
redsun82 merged 5 commits into from
Aug 25, 2026
+10 −10
Merged

Fixes docs for directoryBrowse enabled examples #22419

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
ff5a248
Correct 'enable' to 'enabled' in ASP.NET example
jzabroski Aug 24, 2026
c23b3a9
Fix typo in directoryBrowse attribute
jzabroski Aug 24, 2026
ada881e
Fix directoryBrowse attribute from 'enable' to 'enabled'
jzabroski Aug 24, 2026
7f43245
Potential fix for pull request finding
jzabroski Aug 24, 2026
748fbc7
Fix closing tag
jzabroski Aug 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions csharp/ql/src/Security Features/CWE-548/ASPNetDirectoryListing.qhelp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,13 +21,13 @@ If this configuration may be used in production, remove the <code>directoryBrows
<example>

<p>
The following example shows the <code>directoryBrowse</code> <code>enable</code> attribute set to true in a <code>Web.config</code> file for ASP.NET:
The following example shows the <code>directoryBrowse</code> <code>enabled</code> attribute set to true in a <code>Web.config</code> file for ASP.NET:
</p>

<sample src="Web.config.bad" />

<p>
To fix this problem, the <code>enable</code> attribute should be set to <code>false</code>, or the <code>directoryBrowse</code> element should be removed completely:
To fix this problem, the <code>enabled</code> attribute should be set to <code>false</code>, or the <code>directoryBrowse</code> element should be removed completely:
</p>

<sample src="Web.config.good" />
Expand All @@ -36,8 +36,8 @@ To fix this problem, the <code>enable</code> attribute should be set to <code>fa
<references>

<li>
MSDN:
<a href="https://msdn.microsoft.com/en-us/library/ms691327(v=vs.90).aspx">directoryBrowse element</a>.
Microsoft Learn:
<a href="https://learn.microsoft.com/en-us/iis/configuration/system.webserver/directorybrowse#attributes">directoryBrowse element</a>.
</li>


Expand Down
6 changes: 3 additions & 3 deletions csharp/ql/src/Security Features/CWE-548/Web.config.bad
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<?xml version="1.0" encoding="utf-8" ?>
<configuration>
<system.webServer>
<directoryBrowse enable="true"/>
<directoryBrowse enabled="true"/>
...
</system.web>
</configuration>
</system.webServer>
</configuration>
6 changes: 3 additions & 3 deletions csharp/ql/src/Security Features/CWE-548/Web.config.good
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<?xml version="1.0" encoding="utf-8" ?>
<configuration>
<system.webServer>
<directoryBrowse enable="false"/>
<directoryBrowse enabled="false"/>
...
</system.web>
</configuration>
</system.webServer>
</configuration>
Loading