fix: catch OSError in streaming dispatch_command() - #3925
Open
Quratulain-bilal wants to merge 1 commit into
Open
fix: catch OSError in streaming dispatch_command()#3925Quratulain-bilal wants to merge 1 commit into
Quratulain-bilal wants to merge 1 commit into
Conversation
…utable binaries The streaming branch only caught KeyboardInterrupt but not OSError. If the binary is removed between shutil.which() and subprocess.run() (a TOCTOU race), an OSError propagates unhandled.
Contributor
There was a problem hiding this comment.
Pull request overview
Handles streaming command-launch failures caused by executable TOCTOU races.
Changes:
- Converts streaming
OSErrorexceptions into structured failure results. - Applies consistent handling to base and Copilot dispatch paths.
- Regression tests are still needed.
Show a summary per file
| File | Description |
|---|---|
src/specify_cli/integrations/base.py |
Handles streaming execution errors. |
src/specify_cli/integrations/copilot/__init__.py |
Adds equivalent Copilot handling. |
Review details
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
- Files reviewed: 2/2 changed files
- Comments generated: 2
- Review effort level: Balanced
Comment on lines
+404
to
+409
| except OSError as exc: | ||
| return { | ||
| "exit_code": 1, | ||
| "stdout": "", | ||
| "stderr": f"Failed to execute command: {exc}", | ||
| } |
Comment on lines
+317
to
+322
| except OSError as exc: | ||
| return { | ||
| "exit_code": 1, | ||
| "stdout": "", | ||
| "stderr": f"Failed to execute command: {exc}", | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The streaming branch only caught
KeyboardInterruptbut notOSError. If the binary is removed betweenshutil.which()andsubprocess.run()(TOCTOU race), anOSErrorpropagates unhandled.Fix
Added
except OSErrorhandler in both base and copilot streaming dispatch.