refactor(theme): source the base colour tokens from Primer - #3148
Open
afonsojramos wants to merge 2 commits into
Open
refactor(theme): source the base colour tokens from Primer#3148afonsojramos wants to merge 2 commits into
afonsojramos wants to merge 2 commits into
Conversation
Replace the Tailwind palette literals behind the scrollbar and counter tokens with Primer design tokens, resolving the long-standing TODO. Primer tokens resolve per colour scheme on the wrapper, so these now follow the accessibility and high-contrast palettes (the literals stayed frozen), and the `light-dark()` pairs become unnecessary except for the two tokens with an intentional light/dark asymmetry. Counter pills move to the accent-muted / neutral-muted fills GitHub itself uses; Glass is unaffected, it overrides pill fills with its own tokens.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Stacked on #3130. Resolves the long-standing
TODOintailwind.config.mtsby replacing the six Tailwind palette literals (scrollbar track/thumb/thumb-hover, counter primary/secondary/text) with Primer design tokens.[data-color-mode]wrapper, so these now follow the colorblind / Tritanopia / Soft dark / high-contrast palettes — the literals stayed frozen at generic gray/blue regardless of scheme.light-dark()shims become unnecessary for them; only--gitify-backgroundand--gitify-account-error-bgkeep it, as their light/dark asymmetry is an intentional design choice rather than scheme resolution.blue.300/gray.200to the--bgColor-accent-muted/--bgColor-neutral-mutedfills GitHub itself uses, softer and scheme-aware. Glass is unaffected (it overrides pill fills with its own glass tokens).Mappings (light-scheme values for comparison):
gray.100--bgColor-muted(#f6f8fa)gray.300(#d1d5db)--borderColor-default(#d1d9e0)gray.400--borderColor-emphasis(#818b98)blue.300--bgColor-accent-muted(#ddf4ff)gray.200--bgColor-neutral-mutedgray.800--fgColor-defaultVerified token resolution in the built app across Classic light / dark / System / Soft dark — under Soft dark the pills and background now pick up the dimmed palette (
#4184e41a,#262c36) instead of the frozen literals.